Bug 248956 - sysutils/ipmitool: current llvm 11.0.0 -fno-common fallout
Summary: sysutils/ipmitool: current llvm 11.0.0 -fno-common fallout
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Craig Leres
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-08-28 05:12 UTC by Craig Leres
Modified: 2020-09-01 22:06 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (zi)

Attachments
patch (1.92 KB, patch)
2020-08-28 05:12 UTC, Craig Leres 		leres: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer freebsd_triage 2020-08-28 05:12:06 UTC 
A system running current (r364847) fails to build ipmitool with linker errors:

    /bin/sh ../libtool --silent  --tag=CC   --mode=link cc  -O2 -pipe  -I/usr/include -fstack-protector-strong -fno-strict-aliasing  -Wall -Wextra -std=gnu99 -pedantic -Wformat -Wformat-nonliteral -D__BSD_VISIBLE  -L/usr/lib -L/usr/local/lib  -fstack-protector-strong  -o ipmievd ipmievd.o ../lib/libipmitool.la plugins/libintf.la -lreadline -ltinfo -lreadline -ltinfo  -lcrypto
    ld: error: duplicate symbol: gVersionInfo
    >>> defined at ipmitool.c
    >>>            ipmitool.o:(gVersionInfo)
    >>> defined at ipmi_hpmfwupg.c
    >>>            ipmi_hpmfwupg.o:(.bss+0x0) in archive ../lib/.libs/libipmitool.a

This was fixed upstream early this year, here is a patch derived from on:

    https://github.com/ipmitool/ipmitool/commit/c3939dac2c060651361fc71516806f9ab8c38901.patch

"hpmfwupg: move variable definition to .c file"
Comment 1 Craig Leres freebsd_committer freebsd_triage 2020-08-28 05:12:37 UTC 
Created attachment 217579 [details]
patch
Comment 2 Craig Leres freebsd_committer freebsd_triage 2020-09-01 22:06:16 UTC 
@se committed a similar patch in r547241