Bug 248963 - graphics/waffle: update to 1.6.1 - fixes fno-common build
Summary: graphics/waffle: update to 1.6.1 - fixes fno-common build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
Depends on:
Reported: 2020-08-28 12:34 UTC by Greg V
Modified: 2020-09-17 10:16 UTC (History)
1 user (show)

See Also:
zeising: maintainer-feedback+
zeising: merge-quarterly?

waffle-161.patch (3.59 KB, patch)
2020-08-28 12:34 UTC, Greg V
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg V 2020-08-28 12:34:04 UTC
Created attachment 217584 [details]

Waffle 1.6.1 includes a fix for -fno-common: https://gitlab.freedesktop.org/mesa/waffle/-/merge_requests/70

Tested with apitrace. ABI didn't break.

Switching to new xdg-shell MR that works with the current version: https://gitlab.freedesktop.org/mesa/waffle/-/merge_requests/76
Comment 1 commit-hook freebsd_committer 2020-08-28 17:02:45 UTC
A commit references this bug:

Author: zeising
Date: Fri Aug 28 17:02:36 UTC 2020
New revision: 546757
URL: https://svnweb.freebsd.org/changeset/ports/546757

  graphics/waffle: Update to 1.6.1

  Update graphics/waffle.  This fixes the build with -fno-common.
  Switch to new version of the patches for xdg-shell.

  PR:		248963
  Submitted by:	Greg V
  MFH:		2020Q3

Comment 2 Niclas Zeising freebsd_committer 2020-08-28 17:05:02 UTC
Waiting for MFH
Comment 3 Niclas Zeising freebsd_committer 2020-09-17 10:16:24 UTC
The waffle update broke piglit.  Piglit has been fixed in head, but there is no intention to merge the piglit update back to the Q3 branch.
Since the Q4 branch is just a couple of weeks away, I see no reason to MFH this update, we can wait for the new branch instead.