Bug 248985 - net-p2p/libtorrent-rasterbar: Use release archive and minor changes to Makefile
Summary: net-p2p/libtorrent-rasterbar: Use release archive and minor changes to Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-29 07:52 UTC by daniel.engberg.lists
Modified: 2020-08-29 15:16 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Patch for libtorrent-rasterbar (1.74 KB, patch)
2020-08-29 07:52 UTC, daniel.engberg.lists
no flags Details | Diff
Patch for libtorrent-rasterbar v2 (2.07 KB, patch)
2020-08-29 10:50 UTC, daniel.engberg.lists
no flags Details | Diff
Patch for libtorrent-rasterbar v3 (2.07 KB, patch)
2020-08-29 10:53 UTC, daniel.engberg.lists
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description daniel.engberg.lists 2020-08-29 07:52:24 UTC
Created attachment 217610 [details]
Patch for libtorrent-rasterbar

Use release archive instead of pulling source from GitHub repo as suggested by 5.4.3 in Porter's Handbook

Use USES= localbase:ldflags instead of defining it manually

Tested on FreeBSD 13.0-CURRENT #0 r358620 (AMD64) (make test)
Comment 1 daniel.engberg.lists 2020-08-29 10:50:24 UTC
Created attachment 217612 [details]
Patch for libtorrent-rasterbar v2

Fix "make test"
Comment 2 daniel.engberg.lists 2020-08-29 10:51:16 UTC
1.2.9 hangs on "91 - test_web_seed_http" running "make test".
Comment 3 daniel.engberg.lists 2020-08-29 10:53:15 UTC
Created attachment 217613 [details]
Patch for libtorrent-rasterbar v3

Wrong patch, don't remove PORTREVISION. Sorry!
Comment 4 Yuri Victorovich freebsd_committer 2020-08-29 15:16:14 UTC
Committed with some additions.

Thanks!
Comment 5 commit-hook freebsd_committer 2020-08-29 15:16:23 UTC
A commit references this bug:

Author: yuri
Date: Sat Aug 29 15:16:11 UTC 2020
New revision: 546921
URL: https://svnweb.freebsd.org/changeset/ports/546921

Log:
  net-p2p/libtorrent-rasterbar: Use release archive; Fix python executable path for tests; Remove unnecessary patch and comment in Makefile

  PR:		248985
  Submitted by:	daniel.engberg.lists@pyret.net (initial version)

Changes:
  head/net-p2p/libtorrent-rasterbar/Makefile
  head/net-p2p/libtorrent-rasterbar/distinfo