Bug 249011 - x11/xmascot: Fix -fno-common error
Summary: x11/xmascot: Fix -fno-common error
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
Depends on:
Blocks: 248756
  Show dependency treegraph
Reported: 2020-08-30 11:00 UTC by Yoshihiro Takahashi
Modified: 2021-01-19 02:38 UTC (History)
4 users (show)

See Also:
koobs: merge-quarterly?

Commercial use is prohibited (598 bytes, patch)
2020-08-30 11:00 UTC, Yoshihiro Takahashi
no flags Details | Diff
Update the port (1.72 KB, application/x-bzip)
2020-08-30 11:03 UTC, Yoshihiro Takahashi
no flags Details
diff (1.64 KB, application/x-bzip)
2020-09-01 03:29 UTC, Yoshihiro Takahashi
no flags Details
xmascot diff (3.50 KB, patch)
2020-09-01 09:25 UTC, Yoshihiro Takahashi
no flags Details | Diff
poudriere testport log on 13.0-ALPHA1 with the patch (39.93 KB, text/plain)
2021-01-19 02:38 UTC, WATANABE Kazuhiro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshihiro Takahashi freebsd_committer 2020-08-30 11:00:22 UTC
Created attachment 217644 [details]
Commercial use is prohibited

I have fixed -fno-common error and changed the followings.

- Add LEGAL because commercial use is prohibited.
- Fix -fno-common error and warnings.
- Remove files/* patch that merged to distfile.
- Use Github.
- Install X11 resource file for UTF-8.
Comment 1 Yoshihiro Takahashi freebsd_committer 2020-08-30 11:03:24 UTC
Created attachment 217645 [details]
Update the port

I forgot to attach the file.
Comment 2 Rene Ladan freebsd_committer 2020-08-31 17:50:27 UTC
Can you submit an actual diff instead of a zip file?
Comment 3 Yoshihiro Takahashi freebsd_committer 2020-09-01 03:29:14 UTC
Created attachment 217683 [details]

I attache the diff.
Comment 4 Mathieu Arnold freebsd_committer 2020-09-01 06:19:12 UTC
Could you submit an actual diff and not a compressed file, so that one can view it directly here without having to download the thing?
Comment 5 Yoshihiro Takahashi freebsd_committer 2020-09-01 09:25:18 UTC
Created attachment 217689 [details]
xmascot diff

I have updated again.
Sorry for inconvenience.
Comment 6 WATANABE Kazuhiro 2021-01-19 02:38:31 UTC
Created attachment 221722 [details]
poudriere testport log on 13.0-ALPHA1 with the patch


I've tested the patch on 13.0-ALPHA1 and build/run is fine.