Bug 249018 - emulators/wine-devel: add option to use emulators/dosbox or emulators/dosbox-staging
Summary: emulators/wine-devel: add option to use emulators/dosbox or emulators/dosbox-...
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-30 19:17 UTC by VVD
Modified: 2020-09-27 17:18 UTC (History)
4 users (show)

See Also:
gerald: maintainer-feedback-


Attachments
add option to use emulators/dosbox or emulators/dosbox-staging (2.28 KB, patch)
2020-08-30 19:17 UTC, VVD
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2020-08-30 19:17:32 UTC
Created attachment 217657 [details]
add option to use emulators/dosbox or emulators/dosbox-staging

Testing on 12.1 amd64.
Comment 1 Li-Wen Hsu freebsd_committer 2020-09-01 11:24:11 UTC
Over to maintainer.
Comment 2 VVD 2020-09-13 07:29:55 UTC
Gerald, something wrong with patch?
Comment 3 Gerald Pfeifer freebsd_committer 2020-09-13 12:08:25 UTC
(In reply to VVD from comment #2)
> Gerald, something wrong with patch?

No, and sorry for the delay.

I would prefer not to take this into the port, since it complicates the
port and adds (yet) another thing I cannot actually test and not really
maintain.

Is this important for you? Do you have a particular use case/reason?
Comment 4 VVD 2020-09-13 12:30:43 UTC
(In reply to Gerald Pfeifer from comment #3)
AFAIU, dosbox-staging is more active project: https://dosbox-staging.github.io/about/

Use SDL2 (I want remove old SDL 1.2 from my hosts).
Other differences are here:
https://github.com/dosbox-staging/dosbox-staging#summary-of-differences-compared-to-upstream
Comment 5 Max Brazhnikov freebsd_committer 2020-09-13 12:59:12 UTC
The patch for wine doesn't fix any bug, it's an enhancement, therefore it should be submitted directly upstream. As for new DOSBOX option I leave it to maintainer discretion.
Comment 6 Gerald Pfeifer freebsd_committer 2020-09-26 07:08:39 UTC
(In reply to Max Brazhnikov from comment #5)
> The patch for wine doesn't fix any bug, it's an enhancement, therefore
> it should be submitted directly upstream. As for new DOSBOX option I leave
> it to maintainer discretion.

I agree, and will submit a variation to Wine upstream.  Good point, Max!(In reply to VVD from comment #4)

(In reply to VVD from comment #4)
> AFAIU, dosbox-staging is more active project:
> https://dosbox-staging.github.io/about/

Sorry for the delay on this, VVD.  What do you think, could we simply 
*replace* the flavor of DOSBOX used?  Or should we go for your original
proposal with both options?
Comment 7 Gerald Pfeifer freebsd_committer 2020-09-27 17:18:27 UTC
As a (possibly relevant) note on this, the topic of SDL also came up in the
context of bug#249869.