Bug 249030 - editors/texstudio: Fix build breakage (empy statement)
Summary: editors/texstudio: Fix build breakage (empy statement)
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexandre C. Guimarães
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-31 12:27 UTC by Rainer Hurling
Modified: 2020-09-03 02:47 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rigoletto)


Attachments
fixes build breakage because of empty statement (353 bytes, text/plain)
2020-08-31 12:27 UTC, Rainer Hurling
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer 2020-08-31 12:27:36 UTC
Created attachment 217669 [details]
fixes build breakage because of empty statement

Trying to build editors/texstudio (3.0.0) on CURRENT amd64 breaks with the following error:

-------------------------------
src/texstudio.cpp:3603:11: error: fallthrough attribute is only allowed on empty statements
        [[gnu::fallthrough]]
          ^
src/texstudio.cpp:3603:29: note: did you forget ';'?
        [[gnu::fallthrough]]
                            ^
                            ;
-------------------------------

This seems to be related to [1], which describes the need of a ';' at the end of a code line with only an compiler attribute, especially for clang compilers. Not sure, if gcc10 also needs the semicolon.

Anyway, the attached patch, saved in the port under files/, makes editors/texstudio buildable (on CURRENT) again.


[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=7652#c28
Comment 1 commit-hook freebsd_committer 2020-09-03 02:46:59 UTC
A commit references this bug:

Author: rigoletto
Date: Thu Sep  3 02:46:49 UTC 2020
New revision: 547402
URL: https://svnweb.freebsd.org/changeset/ports/547402

Log:
  editors/texstudio: Fix build on -CURRENT.

  PR:		249030
  Submitted by:	rhurlin

Changes:
  head/editors/texstudio/files/patch-src_texstudio.cpp
Comment 2 Alexandre C. Guimarães freebsd_committer 2020-09-03 02:47:52 UTC
It was apparently just affecting -CURRENT.

Thank you. :-)