Created attachment 217679 [details]
Add patch to fix APC BE600M1 reporting
Reading here  and using the patch mentioned here  I was able to
get apcupsd running on 12.1 to correctly report data from a BE600M1.
Also, some functions in apctest now work as well.
portlint: ok? 1 expected warning about /sbin/shutdown
testport: ok. 12amd64.
current review: https://reviews.freebsd.org/D26259
Hoping to get others feedback on the C++ and if this causes any issues on other APC UPS.
Thanks for the patch.
I read the maillist, it's a pity that the author still didn't answer it, maybe you can give your feedback, helping resurrect this thread.
For now, I think it's more prudent we push this patch as an option, initially not enabled as default, so we can have more users testing it, is that ok for you?
Yeah, that seems like a better idea. Maybe include in the pkg-message to enable the option if you see any reporting oddities?
(In reply to Derek Schrock from comment #3)
Good idea about the pkg-message... it's possible to let a link to this PR as well.
I can produce a patch later today to address this.
Created attachment 217757 [details]
Turn into an optional patch with pkg-message
A commit references this bug:
Date: Fri Sep 4 23:39:39 UTC 2020
New revision: 547577
sysutils/apcupsd: Add patch to fix APC BE600M1 reporting
Patch not enabled as default (initially), so we can have more users testing it.
Submitted by: Derek Schrock <firstname.lastname@example.org>
Differential Revision: https://reviews.freebsd.org/D26259
Committed, thanks for your work!