Bug 249063 - lang/python-doc-html incorrect distinfo
Summary: lang/python-doc-html incorrect distinfo
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Danilo G. Baio
URL:
Keywords:
Depends on: 249537
Blocks:
  Show dependency tree / graph
 
Reported: 2020-09-02 14:27 UTC by George Mitchell
Modified: 2021-05-12 01:11 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (python)

Attachments
distinfo patch (1.01 KB, patch)
2020-09-02 14:27 UTC, George Mitchell 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Mitchell 2020-09-02 14:27:07 UTC 
Created attachment 217705 [details]
distinfo patch

The distinfo entry for python-3.8.5-docs-html.tar.bz2 appears to be incorrect based on the 20 July version that's available at python.org.  I've attached a patch against ports/head version 546287.
Comment 1 Craig Leres freebsd_committer freebsd_triage 2020-09-22 22:03:08 UTC 
I added a dependency on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249537 which will fix makesum for lang/python-doc-html.
Comment 2 Craig Leres freebsd_committer freebsd_triage 2020-11-16 15:56:26 UTC 
lang/python-doc-html uses two different values for MASTER_SITES; for most targets it is set based on the DEFAULT_VERSIONS setting of python:

    zinc 164 # make -C /usr/ports/lang/python-doc-html -V MASTER_SITES
    https://www.python.org/ftp/python/doc/3.7.9/ https://www.python.org/ftp/python/doc/current/

But when the target is makesum, the port's Makefile sets MASTER_SITES (like DISTFILES) to reflect all supported versions of python:

    zinc 169 # make -C /usr/ports/lang/python-doc-html -V MASTER_SITES makesum
    https://www.python.org/ftp/python/doc/2.7.18/:2x7x18 https://www.python.org/ftp/python/doc/3.6.12/:3x6x12 https://www.python.org/ftp/python/doc/3.7.9/:3x7x9 https://www.python.org/ftp/python/doc/3.8.6/:3x8x6 https://www.python.org/ftp/python/doc/3.9.0/:3x9x0 https://www.python.org/ftp/python/doc/current/

But because Mk/bsd.port.mk now does a sub-make for makesum, the carefully constructed MASTER_SITES value is getting stripped when trying to generate a new distinfo.

I guess I don't understand why it's ok for Mk/bsd.port.mk to pass DISTFILES to the makesum sub-make but not MASTER_SITES?