Bug 249116 - net/gnu-dico: update to 2.10
Summary: net/gnu-dico: update to 2.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Fernando Apesteguía
URL: http://savannah.gnu.org/forum/forum.p...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-04 21:16 UTC by info
Modified: 2020-11-07 16:50 UTC (History)
3 users (show)

See Also:
fernape: maintainer-feedback? (info)
fernape: merge-quarterly+


Attachments
diff with update (2.10 KB, patch)
2020-09-04 21:16 UTC, info
no flags Details | Diff
Patch to the ports tree (3.13 KB, patch)
2020-11-05 12:19 UTC, Fernando Apesteguía
fernape: maintainer-approval? (info)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description info 2020-09-04 21:16:42 UTC
Created attachment 217755 [details]
diff with update

- upgrade to version 2.10
- add new swedish translation
- remove no longer needed patches
- update maintainer e-mail address
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2020-09-04 21:16:42 UTC
Maintainer informed via mail
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2020-09-06 17:02:05 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: the port could use some linters too.

Thanks!
Comment 3 info 2020-09-07 02:12:15 UTC
GNU dico - News: Version 2.10

This is a bugfix release, that fixes compilation with gcc 10 and restores the po files, which were absent in the two previous releases due to the packaging error.
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2020-09-27 14:24:43 UTC
Hi,

Updating maintainers email address means it is the same person, right?

(So, no maintainer approval from another person needed ...)
Comment 5 info 2020-11-05 02:49:15 UTC
Yes, that is correct, the maintainer is the same, the email address changed.

Anything else needed to update this port?
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2020-11-05 12:19:44 UTC
Created attachment 219369 [details]
Patch to the ports tree
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2020-11-05 12:20:04 UTC
(In reply to info from comment #5)
When you say "remove no longer needed patches", what are you referring to? The patch does not remove anything in files/

Also, the port does not build in 11_4 and is not marked as BROKEN. It should use LDCONFIG+= -lthr

As I mentioned before, this port could use some clean up.

See attached patch.
Comment 8 info 2020-11-06 23:01:35 UTC
info in comment is referring to changes in attachment #21775 [details], removed patches are on lines 56, 61, 62, 63.
your attachment #219369 [details] looks good to me, you can go ahead and commit it.
Comment 9 commit-hook freebsd_committer freebsd_triage 2020-11-07 16:48:03 UTC
A commit references this bug:

Author: fernape
Date: Sat Nov  7 16:47:26 UTC 2020
New revision: 554408
URL: https://svnweb.freebsd.org/changeset/ports/554408

Log:
  net/gnu-dico: update to 2.10

  ChangeLog: http://savannah.gnu.org/forum/forum.php?forum_id=9806

  Change maintainer's email address.

  PR:	249116
  Submitted by:	info@dikt.tv (maintainer)
  MFH:	2020Q4 (blanket, bug fix release)

Changes:
  head/net/gnu-dico/Makefile
  head/net/gnu-dico/distinfo
  head/net/gnu-dico/pkg-plist
Comment 10 commit-hook freebsd_committer freebsd_triage 2020-11-07 16:50:05 UTC
A commit references this bug:

Author: fernape
Date: Sat Nov  7 16:49:59 UTC 2020
New revision: 554409
URL: https://svnweb.freebsd.org/changeset/ports/554409

Log:
  MFH: r554408

  net/gnu-dico: update to 2.10

  ChangeLog: http://savannah.gnu.org/forum/forum.php?forum_id=9806

  Change maintainer's email address.

  PR:	249116
  Submitted by:	info@dikt.tv (maintainer)

  Approved by:	ports-secteam (blanket, bug fix release)

Changes:
_U  branches/2020Q4/
  branches/2020Q4/net/gnu-dico/Makefile
  branches/2020Q4/net/gnu-dico/distinfo
  branches/2020Q4/net/gnu-dico/pkg-plist
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2020-11-07 16:50:48 UTC
Committed and MFHed,

Thanks!