Bug 249148 - editors/jove: Update to 4.17.0.5
Summary: editors/jove: Update to 4.17.0.5
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-09-06 10:08 UTC by Gian-Simon Purkert
Modified: 2020-09-10 17:19 UTC (History)
1 user (show)

See Also:


Attachments
Update to 4.17.0.5 (9.63 KB, patch)
2020-09-06 10:08 UTC, Gian-Simon Purkert
no flags Details | Diff
jove_update_4.17.0.5.diff (10.06 KB, patch)
2020-09-09 13:45 UTC, Gian-Simon Purkert
no flags Details | Diff
Update to 4.17.0.5 (9.75 KB, patch)
2020-09-09 14:06 UTC, Gian-Simon Purkert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gian-Simon Purkert 2020-09-06 10:08:21 UTC
Created attachment 217789 [details]
Update to 4.17.0.5
Comment 1 Fernando Apesteguía freebsd_committer 2020-09-06 17:09:38 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!
Comment 2 Fernando Apesteguía freebsd_committer 2020-09-07 15:47:06 UTC
Port does not build:

cc  -O -Wall -pedantic -DBSDPOSIX_STDC -c portsrv.c -o portsrv.o
--- doc/cmds.doc ---
LANG=C nroff -Tascii doc/cmds.macros.nr doc/cmds.nr > doc/cmds.doc
sh: nroff: not found
*** [doc/cmds.doc] Error code 127

make[1]: stopped in /wrkdirs/usr/ports/editors/jove/work/jove-4.17.0.5
1 error

make[1]: stopped in /wrkdirs/usr/ports/editors/jove/work/jove-4.17.0.5
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Would you mind checking this?

Thanks!
Comment 3 Gian-Simon Purkert 2020-09-09 13:45:46 UTC
Created attachment 217844 [details]
jove_update_4.17.0.5.diff

Added "BUILD_DEPENDS= nroff:textproc/groff" for EXTRADOCS Option
Comment 4 Gian-Simon Purkert 2020-09-09 14:06:41 UTC
Created attachment 217845 [details]
Update to 4.17.0.5
Comment 5 Fernando Apesteguía freebsd_committer 2020-09-10 17:06:42 UTC
This does not build in poudriere:

====> Running Q/A tests (stage-qa)
Error: 'bin/teachjove' is referring to /wrkdirs/usr/ports/editors/jove/work/stage
Error: 'bin/jove' is referring to /wrkdirs/usr/ports/editors/jove/work/stage
Error: 'lib/jove/recover' is referring to /wrkdirs/usr/ports/editors/jove/work/stage
*** Error code 1

This usually comes up when there are some hardcoded links around.

Would you have a look?

Cheers!
Comment 6 Fernando Apesteguía freebsd_committer 2020-09-10 17:19:52 UTC
In your patch, files/ is deleted, but why? At least portions in patch-Makefile seem to do the trick with the hardcoded paths.