Bug 249252 - x11-fonts/sourcesanspro-ttf needs entry in UPDATING
Summary: x11-fonts/sourcesanspro-ttf needs entry in UPDATING
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-11 11:45 UTC by tech-lists
Modified: 2022-04-08 17:34 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tech-lists 2020-09-11 11:45:03 UTC
Hi,

The name of this font has changed to include the version number. Can something about this be put in /usr/ports/UPDATING ? Because otherwise it's easy to miss.

It's not like there has been a major change in version, or of the port name. But the font name is now completely different and this will affect everything that uses it.

Before: (version 3.006)

/usr/local/share/fonts/SourceSansPro
/usr/local/share/fonts/SourceSansPro/.uuid
/usr/local/share/fonts/SourceSansPro/SourceSansPro-Black.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-BlackIt.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-Bold.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-BoldIt.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-ExtraLight.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-ExtraLightIt.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-It.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-Light.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-LightIt.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-Regular.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-Semibold.ttf
/usr/local/share/fonts/SourceSansPro/SourceSansPro-SemiboldIt.ttf

after: (version 3.028)

/usr/local/share/fonts/SourceSansPro
/usr/local/share/fonts/SourceSansPro/.uuid
/usr/local/share/fonts/SourceSansPro/SourceSans3-Black.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-BlackIt.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-Bold.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-BoldIt.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-ExtraLight.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-ExtraLightIt.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-It.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-Light.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-LightIt.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-Regular.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-Semibold.ttf
/usr/local/share/fonts/SourceSansPro/SourceSans3-SemiboldIt.ttf
Comment 1 tech-lists 2022-02-03 20:02:36 UTC
This got broken again in https://cgit.freebsd.org/ports/commit/?id=74953fa06f715a05f160d1ab32a58281aba4eb27 where the portname and the font name changed.

An entry is present in /usr/ports/MOVED for this but it's not just moving it's changing name. 
Why isn't this in UPDATING ??
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-04-08 07:30:22 UTC
(In reply to tech-lists from comment #1)
Thanks for reporting this.

I agree that, since this update requires special actions to be successful, there should have been an entry in UPDATED. Unfortunately people have learned about this the hard way.

While I fully agree that this should have been done, I do not see the benefits of adding the entry in UPDATING at this point in time more than 1.5 years after the problem.

Would you agree?
Comment 3 tech-lists 2022-04-08 13:44:41 UTC
(In reply to Fernando Apesteguía from comment #2)

Hi,

you wrote:

> While I fully agree that this should have been done, I do not see the benefits > of adding the entry in UPDATING at this point in time more than 1.5 years after > the problem.

> Would you agree?

I agree with respect to the initial report, as you say it was long ago. But the problem happened again, on 2022-01-28, referenced in comment #1, which is relatively recent, and an entry may be of utility to users upgrading to now from around that time.

Thank you for looking at this.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2022-04-08 17:34:01 UTC
Note added to UPDATING.

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-04-08 17:34:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=71ec3a62b70a6e75681cfbcc6e61abc207f731e3

commit 71ec3a62b70a6e75681cfbcc6e61abc207f731e3
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-04-08 17:24:42 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-04-08 17:30:42 +0000

    UPDATING: add entry for x11-fonts/sourcesanspro-ttf

    Font name changed. This is easy to miss and might cause problems.
    Add a note as suggested in the PR.

    PR:     249252
    Reported by:    tech-lists@zyxst.net
    Fixes:  74953fa06f715a05f160d1ab32a58281aba4eb27

 UPDATING | 8 ++++++++
 1 file changed, 8 insertions(+)