Bug 249273 - pkgbase: missing colon in /usr/src/release/packages/runtime.ucl
Summary: pkgbase: missing colon in /usr/src/release/packages/runtime.ucl
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Kyle Evans
URL:
Keywords: patch, pkgbase
Depends on:
Blocks:
 
Reported: 2020-09-12 08:36 UTC by Martin
Modified: 2020-09-18 14:29 UTC (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin 2020-09-12 08:36:35 UTC
There is a colon missing in the /usr/src/release/packages/runtime.ucl file, see below.

--- /usr/src/release/packages/runtime.ucl       2019-06-02 09:09:55.106842000 +0200
+++ runtime.ucl 2020-09-12 09:21:57.013004000 +0200
@@ -30,7 +30,7 @@
         version: "%VERSION%"
     }
 }
-directories {
+directories: {
     /dev = "y";
     /tmp = "y";
 }
Comment 1 Allan Jude freebsd_committer 2020-09-18 13:46:01 UTC
It is not required

As explained here:

https://github.com/vstakhov/libucl/#general-syntax-sugar

key = value;
section {
    key = value;
}

is equivalent to

{
    "key": "value",
    "section": {
        "key": "value"
    }
}


However, it would likely be stylistically better to be consistent throughout the file.
Comment 2 commit-hook freebsd_committer 2020-09-18 14:29:17 UTC
A commit references this bug:

Author: kevans
Date: Fri Sep 18 14:29:02 UTC 2020
New revision: 365883
URL: https://svnweb.freebsd.org/changeset/base/365883

Log:
  pkgbase: use consistent annotation for objectk eys

  Everywhere else we use objects ("scripts", generally) we do sepcify the
  optional colon. Be consistent and do the same for directories.

  PR:		249273
  Submitted by:	Martin <martin.jakob gmx com>
  MFC after:	1 week

Changes:
  head/release/packages/runtime.ucl