Bug 249327 - fix IP address parsing in netgraph eating too many characters
Summary: fix IP address parsing in netgraph eating too many characters
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.1-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-net (Nobody)
URL: https://reviews.freebsd.org/D26489
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-09-15 05:59 UTC by Markus Stoff
Modified: 2020-11-01 01:20 UTC (History)
0 users

See Also:
koobs: mfc-stable12?

Attachments
Suggested fix for ng_parse.c (506 bytes, patch)
2020-09-15 05:59 UTC, Markus Stoff 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Stoff 2020-09-15 05:59:08 UTC 
Created attachment 217966 [details]
Suggested fix for ng_parse.c

The IP address parse type in ng_parse.c eats one character to much on the input.

Example:

Given '{ inet=10.0.0.1 }', after the IP address has been parsed the next character on the input should be the space (' '), but instead it is the closing curly brace '}'.
Comment 1 Markus Stoff 2020-09-20 19:52:54 UTC 
See also review D26489.
Comment 2 Markus Stoff 2020-10-31 19:07:24 UTC 
The proposed fix has been approved in review D26489.
Comment 3 Bjoern A. Zeeb freebsd_committer freebsd_triage 2020-10-31 19:26:09 UTC 
I added #network to the review so that a committer might also have a look and deal with this.