Bug 249392 - audio/libcanberra: Add gtk2 slave port
Summary: audio/libcanberra: Add gtk2 slave port
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL: https://reviews.freebsd.org/D20830
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-17 12:50 UTC by Olivier Duchateau
Modified: 2022-01-31 18:26 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+

Attachments
Patch for new slave port (9.82 KB, patch)
2020-09-17 12:50 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2020-09-17 12:50:52 UTC 
Created attachment 218024 [details]
Patch for new slave port

- Add Gtk+ 2 bindings for libcanberra
- Bump PORTREVISION (audio/libcanberra)
- Adjust dependencies
- Move some Gtk files in -gtk3 slave port instead of -gtk2 (it is more useful for update of GNOME ports).
Comment 1 Tobias C. Berner freebsd_committer 2020-09-17 17:05:05 UTC 
Moin moin 

Thank you!

I prepared even more child ports some time ago -- do you have time to see if that still makes sense?


mfg Tobias
Comment 2 Val Packett 2020-12-05 00:53:43 UTC 
(In reply to Tobias C. Berner from comment #1)

+1 on D20830, provided gtk3 apps don't get the gtk2 dependency :)
Comment 3 Adriaan de Groot freebsd_committer 2022-01-25 12:25:59 UTC 
Greg, Olivier, this got rather bogged down in review, but the review in general was positive. Can you drive this forward again? It might be useful in particular to have a gtk2-less dependency path for libcanberra (for instance for gtk3-only desktops, or whatevs).
Comment 4 Val Packett 2022-01-31 18:26:44 UTC 
I've been rebasing D20830 in my tree all the time, uploaded the current version there, but it does need testing.