Bug 249433 - security/samhain: various housekeeping cleanups
Summary: security/samhain: various housekeeping cleanups
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: buildisok, patch
Depends on:
Blocks:
 
Reported: 2020-09-18 14:05 UTC by Greg Veldman
Modified: 2020-09-26 09:02 UTC (History)
1 user (show)

See Also:
freebsd: maintainer-feedback+


Attachments
various port housekeeping cleanups (2.98 KB, patch)
2020-09-18 14:05 UTC, Greg Veldman
freebsd: maintainer-approval+
Details | Diff
poudriere build log (70.72 KB, text/plain)
2020-09-18 14:14 UTC, Greg Veldman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Veldman 2020-09-18 14:05:45 UTC
Created attachment 218055 [details]
various port housekeeping cleanups

Various housekeeping cleanups for the Samhain port:

- The port comes in three flavors, standalone, -server, and -client.  All three use one or more files under /var/lib.  Remove the logic that only includes that dir in plist for some of those flavors, and include it for all.

- Get rid of .sh extensions on rc scripts.

- Use INSTALL_SCRIPT instead of CP to ensure the rc scripts have useful permissions.

- Patch the rc script source so they properly respect settings in rc.conf.

- Use @postunexec in plist instead of the deprecated @unexec.
Comment 1 Greg Veldman 2020-09-18 14:14:22 UTC
Created attachment 218056 [details]
poudriere build log

Poudriere build log attached, in case it's needed.
Comment 2 Automation User 2020-09-18 14:29:15 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/191708284
Comment 3 Kurt Jaeger freebsd_committer 2020-09-26 09:02:25 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer 2020-09-26 09:02:27 UTC
A commit references this bug:

Author: pi
Date: Sat Sep 26 09:02:14 UTC 2020
New revision: 550138
URL: https://svnweb.freebsd.org/changeset/ports/550138

Log:
  security/samhain: housekeeping

  - The port comes in three flavors, standalone, -server, and -client.
    All three use one or more files under /var/lib.  Remove the logic
    that only includes that dir in plist for some of those flavors,
    and include it for all.
  - Get rid of .sh extensions on rc scripts.
  - Use INSTALL_SCRIPT instead of CP to ensure the rc scripts have
    useful permissions.
  - Patch the rc script source so they properly respect settings in rc.conf.
  - Use @postunexec in plist instead of the deprecated @unexec.

  PR:		249433
  Submitted by:	Greg Veldman <freebsd@gregv.net> (maintainer)

Changes:
  head/security/samhain/Makefile
  head/security/samhain/files/patch-init_samhain.startFreeBSD.in
  head/security/samhain/pkg-plist