Bug 249506 - dns/dnscrypt-wrapper: enable xchacha20
Summary: dns/dnscrypt-wrapper: enable xchacha20
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-21 12:03 UTC by Felix Hanley
Modified: 2020-09-23 18:42 UTC (History)
1 user (show)

See Also:
freebsd: maintainer-feedback+


Attachments
patch to enable xchacha (471 bytes, patch)
2020-09-21 12:03 UTC, Felix Hanley
no flags Details | Diff
patch to enable xchacha v2 (596 bytes, patch)
2020-09-23 05:36 UTC, Will
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Hanley 2020-09-21 12:03:37 UTC
Created attachment 218144 [details]
patch to enable xchacha

This patch enables configuring the build to discover that xchacha _is_ available in libsodium.
Comment 1 Will 2020-09-23 05:36:05 UTC
Created attachment 218203 [details]
patch to enable xchacha v2
Comment 2 Will 2020-09-23 05:37:56 UTC
Thank you very much for your report! I've adjusted your suggested patch to use the autoconf support already provided by FreeBSD's make files, rather than running "make config" manually. The result should be the same, but can you test the new patch I've attached and confirm it still gives your desired result?
Comment 3 Felix Hanley 2020-09-23 05:41:25 UTC
Yes, much nicer, thanks.
Comment 4 Will 2020-09-23 18:42:42 UTC
Comment on attachment 218203 [details]
patch to enable xchacha v2

Great! I'm approving the more recent, "v2" patch attached. Someone will hopefully apply it to the ports tree soon! Thanks again for your contribution.