Bug 249537 - Mk/bsd.port.mk: unbreak makesum for lang/python-doc-html
Summary: Mk/bsd.port.mk: unbreak makesum for lang/python-doc-html
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL: https://reviews.freebsd.org/D27226
Keywords: patch
Depends on:
Blocks: 249063
  Show dependency treegraph
Reported: 2020-09-22 21:56 UTC by Craig Leres
Modified: 2020-11-16 10:06 UTC (History)
2 users (show)

See Also:

patch (525 bytes, patch)
2020-09-22 21:56 UTC, Craig Leres
leres: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer 2020-09-22 21:56:23 UTC
@dbaio reported that "make makesum" was not working for lang/python-doc-html. This was something I had fixed last year via r492965.

r513191 does some cleanup of bsd.prog.mk:

    Reduce code duplication by calling fetch target
    when converting the do-fetch target to proper scripting we lost
    the ability to overwrite do-fetch when running make makesum.
    as reported here: 
    Let's call again do-fetch directly instead of duplicating its

This was a nice cleanup but broke makesum lang/python-doc-html and also some linux ports resulting in r514097:

    Let "make makesum" pass DISTFILES to "make fetch".  For Linux 
    ports "make makesum" downloads distfiles for all supported
    architectures while "make fetch" only downloads files for the
    build architecture.

This partially fixed lang/python-doc-html but MASTER_SITES also needs to be passed down to the sub-make; here's a patch to do that.
Comment 1 Craig Leres freebsd_committer 2020-09-22 21:56:50 UTC
Created attachment 218195 [details]
Comment 2 Mathieu Arnold freebsd_committer 2020-11-16 10:06:46 UTC
It seems to me that the framework does not really need fixing, the port should be fixed instead.
Nothing prevents the port from having the correct MASTER_SITES value outside of make(makesum).