Bug 249562 - 12-STABLE r366067 (likely CURRENT, too) "buildworld" fails with EFI_SECUREBOOT (WITH_LOADER_EFI_SECUREBOOT=t in src.conf(5))
Summary: 12-STABLE r366067 (likely CURRENT, too) "buildworld" fails with EFI_SECUREBOO...
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 12.1-STABLE
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-24 07:25 UTC by Walter von Entferndt
Modified: 2020-09-25 19:47 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Walter von Entferndt 2020-09-24 07:25:25 UTC 
12-STABLE/stand/efi/loader/main.c:1104:2: error: implicit declaration of function 've_efi_init' is invalid in C99
This is a few lines off in CURRENT, but I only built STABLE, not CURRENT
13-CUR/stand/efi/loader/main.c:1135:2:

Obviously lib/libsecureboot/h/verify_file.h must be #included when EFI_SECUREBOOT is defined.  I do not have a patch because that may go into some other header file that is included anyway.

When you fix this: IMHO the coresponding comment above shold be inside the #ifdef.  Rationale: editors supporting text folding will fold the block inside the #ifdef...#endif

Thx in advance.