Created attachment 218296 [details] obhttpd 6.7.20200925 patch Update www/obhttpd to 6.7.20200925. Poudriere logs look good.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/194694227
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. ^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. -- Attachment -> Details -> maintainer-approval [+] ^Triage: Maintainer-feedback flag (+) not required unless requested (?) first. Q/A: Some variables are out of place: # USES block USES -SSL_VERSION -LIBEVENT_VERSION -LIBIMSG_VERSION USE_GITHUB GH_ACCOUNT GH_PROJECT GH_TAGNAME USE_RC_SUBR # Make block +MAKE_ARGS # CFLAGS/CXXFLAGS/LDFLAGS block CFLAGS LDFLAGS -MAKE_ARGS # Users and groups block USERS GROUPS # Unknown variables +LIBEVENT_VERSION +LIBIMSG_VERSION +SSL_VERSION Thanks!
1. https://github.com/koue/httpd/blob/master/ChangeLog 2. Maintainer has to approve its own patch? Useless extra step. 3. Everything is in place: www/obhttpd # make -V PORTVERSION 6.7.20200925 www/obhttpd # portlint looks fine.
(In reply to Nikola Kolev from comment #3) Hi Nikola, 1 - Thanks for that! 2 - It makes the PR database more searchable. 3 - Linters do their best, but the reference is the Handbook. Please check [1]. Variables that are specific to the port and are not part of the framework should go at the end. MAKE block variable should appear earlier. Cheers! [1] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-order