Bug 249910 - irc/irssi: Update to snapshot 1.3 (20200926)
Summary: irc/irssi: Update to snapshot 1.3 (20200926)
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-26 10:04 UTC by daniel.engberg.lists
Modified: 2020-10-19 12:41 UTC (History)
2 users (show)

See Also:
dor.bsd: maintainer-feedback+


Attachments
Patch for irssi (WIP) (10.37 KB, patch)
2020-09-26 10:04 UTC, daniel.engberg.lists
no flags Details | Diff
Patch for irssi v2 (WIP) (9.97 KB, patch)
2020-09-26 13:15 UTC, daniel.engberg.lists
no flags Details | Diff
Patch for irssi v3 (9.97 KB, patch)
2020-09-26 15:10 UTC, daniel.engberg.lists
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description daniel.engberg.lists 2020-09-26 10:04:14 UTC
Created attachment 218315 [details]
Patch for irssi (WIP)

Update irssi to snapshot 1.3.20200911

Includes various bug fixes including ones related to Glib and SSL/TLS

Compile and run-tested FreeBSD 13.0-CURRENT #0 r364979 (AMD64)
Poudriere testport OK 12.1-RELEASE (amd64)
Comment 1 daniel.engberg.lists 2020-09-26 10:10:24 UTC
I forgot to mention, this also switches to Meson

Known issues:

Capsicum fail during configure stage:

Compiler stderr:
 /usr/ports/irc/irssi/work/irssi-561619f/_build/meson-private/tmp4ziugp_n/testfile.c:17:18: error: "__builtin_nvlist_create_found not found"
                #error "__builtin_nvlist_create_found not found"
                 ^
1 error generated.

Portlint complains about TRUECOLOR option and I can't figure out why

WARN: Makefile: TRUECOLOR is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MTRUECOLOR appears.

Help appreciated

Additional notes, I know that not using releases aren't ideal but upstream at least for now has no intention releasing a new version.
Comment 2 daniel.engberg.lists 2020-09-26 13:15:15 UTC
Created attachment 218324 [details]
Patch for irssi v2 (WIP)

Use naming schema in used in example 5.14 (Porters Handbook), suggested by jrm@
Use YES/NO ports framework logic (5.13.3.5.3 in Ports handbook), suggested by jrm@ (I missed that paragraph when I looked at it)

portlint till complains about TRUECOLOR (seems to be a false positive)
Capsicum still doesn't build
Comment 3 daniel.engberg.lists 2020-09-26 15:10:55 UTC
Created attachment 218328 [details]
Patch for irssi v3

Fixes compilation with capsicum
Comment 4 Fernando Apesteguía freebsd_committer 2020-09-30 06:24:50 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!
Comment 5 daniel.engberg.lists 2020-09-30 06:51:41 UTC
Hi,

There isn't one except for the commit log which is too long (GitHub cuts it at 250 commits)
https://github.com/irssi/irssi/compare/1.2.2...master

Best regards,
Daniel
Comment 6 daniel.engberg.lists 2020-10-11 11:04:03 UTC
Regarding users:

irssi-dcc_send_limiter - Build, Run dep (testport OK)
irssi-fish - Build, Run dep (testport OK)
irssi-icb - Build, Run dep (testport OK)
irssi-xmpp - Doesn't compile with new Glib and seems to be broken in general looking at GitHub
irssi-scripts - Just copies files (scripts)
p5-POE-Session-Irssi - Run dep
twirssi - Run dep
irssi-themes -  Run dep
Comment 7 daniel.engberg.lists 2020-10-15 08:18:00 UTC
Reference to glib fix: https://github.com/irssi/irssi/issues/1180
Comment 8 daniel.engberg.lists 2020-10-19 12:15:20 UTC
Friendly ping
Comment 9 David O'Rourke 2020-10-19 12:32:07 UTC
Hi,

Apologies for the silence here, things have been busy recently. I should have some time to look at this properly later in the week.

Thanks,
-David
Comment 10 daniel.engberg.lists 2020-10-19 12:41:48 UTC
Sounds great, thanks!