Bug 249931 - misc/libmodulemd: Use release archive
Summary: misc/libmodulemd: Use release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
Depends on:
Reported: 2020-09-27 06:48 UTC by Daniel Engberg
Modified: 2020-09-27 07:42 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Patch for libmodulemd (1.52 KB, patch)
2020-09-27 06:48 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer 2020-09-27 06:48:01 UTC
Created attachment 218348 [details]
Patch for libmodulemd

Use upstream release archive as suggested in section 5.4.3 in Porter's Handbook.

Compile tested on FreeBSD 13.0-CURRENT #0 r364979 (amd64) (make + make check-plist)
Comment 1 Yuri Victorovich freebsd_committer 2020-09-27 06:55:48 UTC
(In reply to daniel.engberg.lists from comment #0)

Hi Daniel,

Thanks for the patch.

What language in section 5.4.3 in Porter's Handbook suggests to use upstream release archives?

Comment 2 Daniel Engberg freebsd_committer 2020-09-27 07:07:02 UTC
"If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file."
Comment 3 Daniel Engberg freebsd_committer 2020-09-27 07:24:25 UTC

..and by that to my understanding that applies to tags and branches (which both are "commits") as the release archive would be the "officially released file".

Best regards,
Comment 4 Yuri Victorovich freebsd_committer 2020-09-27 07:40:33 UTC
(In reply to daniel.engberg.lists from comment #3)

This must have changed not long ago, because before portlint suggested to use USE_GITHUB=yes when MASTER_SITES contained github.com.
Comment 5 Yuri Victorovich freebsd_committer 2020-09-27 07:41:59 UTC
Committed, thanks!
Comment 6 commit-hook freebsd_committer 2020-09-27 07:42:08 UTC
A commit references this bug:

Author: yuri
Date: Sun Sep 27 07:41:56 UTC 2020
New revision: 550248
URL: https://svnweb.freebsd.org/changeset/ports/550248

  misc/libmodulemd: Use release archive

  PR:		249931
  Submitted by:	daniel.engberg.lists@pyret.net