Bug 249946 - net/nncp: Update to 5.6.0
Summary: net/nncp: Update to 5.6.0
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: http://www.nncpgo.org/Release-5_002e6...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-27 18:08 UTC by Sergey Matveev
Modified: 2021-01-18 08:03 UTC (History)
3 users (show)

See Also:


Attachments
Update patch from 5.3.3 to 5.4.0 (765 bytes, patch)
2020-09-27 18:08 UTC, Sergey Matveev
no flags Details | Diff
Update patch from 5.3.3 to 5.4.1 (765 bytes, patch)
2020-09-27 21:17 UTC, Sergey Matveev
stargrave: maintainer-approval+
Details | Diff
Update patch from 5.3.3 to 5.5.0 (1.59 KB, patch)
2021-01-07 20:53 UTC, Sergey Matveev
stargrave: maintainer-approval+
Details | Diff
diff to unbreak with go1.16 (396 bytes, patch)
2021-01-08 15:55 UTC, Dmitri Goutnik
dmgk: maintainer-approval?
Details | Diff
patch with fix for INFO files (2.94 KB, patch)
2021-01-11 08:16 UTC, Fernando Apesteguía
fernape: maintainer-approval? (stargrave)
Details | Diff
Update to 5.5.1 and unbreak with go1.16 (1.81 KB, patch)
2021-01-11 12:34 UTC, Sergey Matveev
stargrave: maintainer-approval+
Details | Diff
Update to 5.6.0 und unbreak with go1.16 (1.81 KB, patch)
2021-01-18 08:02 UTC, Sergey Matveev
stargrave: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Matveev 2020-09-27 18:08:30 UTC
Created attachment 218366 [details]
Update patch from 5.3.3 to 5.4.0

Update NNCP to 5.4.0.
Comment 1 Sergey Matveev 2020-09-27 21:17:37 UTC
Created attachment 218370 [details]
Update patch from 5.3.3 to 5.4.1
Comment 2 Fernando Apesteguía freebsd_committer 2020-09-30 06:16:44 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]


Thanks!
Comment 3 Sergey Matveev 2020-09-30 18:53:48 UTC
(In reply to Fernando Apesteguía from comment #2)

Added an approval and URL to 5.4.1 release. As I can see, only one URL can be added. But 5.4.0 release just updates dependencies and uses redo build system (however compatibility Makefiles are included, tested on my local machine).
Comment 4 Sergey Matveev 2021-01-07 20:53:52 UTC
Created attachment 221368 [details]
Update patch from 5.3.3 to 5.5.0
Comment 5 Dmitri Goutnik freebsd_committer 2021-01-08 15:55:19 UTC
Created attachment 221390 [details]
diff to unbreak with go1.16

While here, could you please amend the patch to include the attached fix? This unbreaks port build with go1.16. Thanks!
Comment 6 Fernando Apesteguía freebsd_committer 2021-01-08 16:13:14 UTC
(In reply to Dmitri Goutnik from comment #5)
Sure. It is still queued to be build tested :-)
Comment 7 Fernando Apesteguía freebsd_committer 2021-01-09 19:00:27 UTC
(In reply to Fernando Apesteguía from comment #6)

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: info/nncp.info
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.

Does this file need to be included?
Comment 8 Sergey Matveev 2021-01-09 21:28:17 UTC
(In reply to Fernando Apesteguía from comment #7)
Should be installed, it is the only documentation available. Previously INFO= in the Makefile was enough, strange.
Comment 9 Fernando Apesteguía freebsd_committer 2021-01-11 08:15:23 UTC
(In reply to Dmitri Goutnik from comment #5)
Hi Dmitri,

Even with that patch, I get this on CURRENT:

===>  Building for nncp-5.5.0
--- warning ---
WARNING: this is not real Makefile. Just proxying commands to redo command
--- all ---
contrib/do -c all
do  all
do    bin/all
do      bin/nncp-bundle
do        gopath
do      bin/nncp-call
do      bin/nncp-caller
# go.cypherpunks.ru/nncp/v5/cmd/nncp-caller
unexpected fault address 0x520b42
fatal error: fault
[signal SIGBUS: bus error code=0x3 addr=0x520b42 pc=0x520b42]

goroutine 1 [running]:
runtime.throw(0x6cd22b, 0x5)
        /usr/local/go/src/runtime/panic.go:1116 +0x72 fp=0xc0000d0b30 sp=0xc0000d0b00 pc=0x435912
runtime.sigpanic()
        /usr/local/go/src/runtime/signal_unix.go:739 +0x465 fp=0xc0000d0b60 sp=0xc0000d0b30 pc=0x44c025
cmd/link/internal/loader.(*Loader).migrateAttributes(0xc0006c0000, 0xbfbd, 0x14245c8910244489)
        /usr/local/go/src/cmd/link/internal/loader/loader.go:2655 +0x62 fp=0xc0000d0bf0 sp=0xc0000d0b60 pc=0x520b42
cmd/link/internal/loader.loadObjFull(0xc0006c0000, 0xc000053020, 0xc0029b0000)
        /usr/local/go/src/cmd/link/internal/loader/loader.go:2750 +0x127 fp=0xc0000d0ca0 sp=0xc0000d0bf0 pc=0x521a47
cmd/link/internal/loader.(*Loader).LoadFull(0xc0006c0000, 0x86c760, 0xc0000ae100, 0x0)
        /usr/local/go/src/cmd/link/internal/loader/loader.go:2156 +0xf77 fp=0xc0000d0db8 sp=0xc0000d0ca0 pc=0x51e8d7
cmd/link/internal/ld.(*Link).loadlibfull(0xc0000a7880, 0xc001054000, 0x19352, 0x19352, 0x530000)
        /usr/local/go/src/cmd/link/internal/ld/lib.go:2835 +0x73 fp=0xc0000d0eb8 sp=0xc0000d0db8 pc=0x5d29f3
cmd/link/internal/ld.Main(0x86c760, 0x20, 0x20, 0x1, 0x7, 0x10, 0x0, 0x0, 0x6d87b2, 0x1b, ...)
        /usr/local/go/src/cmd/link/internal/ld/main.go:341 +0x18cc fp=0xc0000d1118 sp=0xc0000d0eb8 pc=0x5e0b0c
main.main()
        /usr/local/go/src/cmd/link/main.go:68 +0x1dc fp=0xc0000d1f88 sp=0xc0000d1118 pc=0x65bd3c
runtime.main()
        /usr/local/go/src/runtime/proc.go:204 +0x209 fp=0xc0000d1fe0 sp=0xc0000d1f88 pc=0x438109
runtime.goexit()
        /usr/local/go/src/runtime/asm_amd64.s:1374 +0x1 fp=0xc0000d1fe8 sp=0xc0000d1fe0 pc=0x469b21
do:     nncp-caller: got exit code 2
do:   all: got exit code 1
do: all: got exit code 1
*** [all] Error code 1

make[1]: stopped in /wrkdirs/usr/ports/net/nncp/work/nncp-5.5.0
1 error

make[1]: stopped in /wrkdirs/usr/ports/net/nncp/work/nncp-5.5.0
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1
Comment 10 Fernando Apesteguía freebsd_committer 2021-01-11 08:16:49 UTC
Created attachment 221449 [details]
patch with fix for INFO files

Upstream Makefile does not seem to honor INFODIR. Add a patch to fix it.
Comment 11 Dmitri Goutnik freebsd_committer 2021-01-11 11:39:57 UTC
(In reply to Fernando Apesteguía from comment #9)
This seems like an unrelated issue with Go linker. Is this with lang/go or lang/go-devel? What version of -CURRENT?
Comment 12 Sergey Matveev 2021-01-11 12:33:52 UTC
(In reply to Fernando Apesteguía from comment #10)
INFODIR honoring was broken when there was move from Makefiles to redo. I fixed it in next minor release: http://www.git.cypherpunks.ru/?p=nncp.git;a=commitdiff;h=2ed9d422314edb2d32f9e23ac39fc5d180d8b1f8

I will attach the patch with updated 5.5.1 checksums and Dmitri's patch to unbreak with go1.16.
Comment 13 Sergey Matveev 2021-01-11 12:34:39 UTC
Created attachment 221456 [details]
Update to 5.5.1 and unbreak with go1.16
Comment 14 Sergey Matveev 2021-01-11 12:47:15 UTC
(In reply to Fernando Apesteguía from comment #9)
That is something strange in the Go's runtime/linker itself. On my machine it works with Go 1.12 till 1.15.6 versions.
Comment 15 Fernando Apesteguía freebsd_committer 2021-01-11 13:05:34 UTC
(In reply to Sergey Matveev from comment #14)

It is in poudriere, but my current might be a bit old (Jail OSVERSION: 1300117). I will update it and try again.

It was using go-1.15.6

===>   nncp-5.5.0 depends on file: /usr/local/bin/go - not found
===>   Installing existing package /packages/All/go-1.15.6,1.txz
[13-current-default] Installing go-1.15.6,1...
[13-current-default] Extracting go-1.15.6,1: .......... done
===>   nncp-5.5.0 depends on file: /usr/local/bin/go - found
Comment 16 Dmitri Goutnik freebsd_committer 2021-01-11 19:41:02 UTC
(In reply to Fernando Apesteguía from comment #9)
Builds fine for me on a recent 13.0-CURRENT snapshot:

# uname -a
FreeBSD freebsd13 13.0-CURRENT FreeBSD 13.0-CURRENT #0 main-c255641-gf2b794e1e90: Thu Jan  7 06:25:26 UTC 2021     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64

# uname -KU
1300133 1300133

# go version
go version go1.15.6 freebsd/amd64
Comment 17 Fernando Apesteguía freebsd_committer 2021-01-12 14:12:39 UTC
(In reply to Dmitri Goutnik from comment #16)
Updated the jail to 1300134. And failed again. But now I got him!

I always use poudriere to build ports. Well, this one works:

sudo poudriere testport -j13-current -p default -o net/nncp

and this one _always_ fails:

sudo poudriere testport -i -j13-current -p default -o net/nncp

The reason to execute with -i is that it is super easy for me to test ports like this from the jail.

So, on my part the patch is OK. If there is no objection, I would like to defer the commit. I would like to ask to other committers about this.
Comment 18 Fernando Apesteguía freebsd_committer 2021-01-14 08:43:05 UTC
I think what happens is very similar to what is described in this issue:

https://github.com/golang/go/issues/42772
Comment 19 Sergey Matveev 2021-01-18 08:02:17 UTC
Created attachment 221695 [details]
Update to 5.6.0 und unbreak with go1.16

Yet another NNCP update. But of course it won't help with linker bugs on FreeBSD.