Bug 249964 - sysutils/lcdproc fix build with -fno-common
Summary: sysutils/lcdproc fix build with -fno-common
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-28 21:31 UTC by Olivier Cochard
Modified: 2020-10-01 12:28 UTC (History)
2 users (show)

See Also:
daniel: maintainer-feedback+


Attachments
patch to fix build (2.55 KB, patch)
2020-09-28 21:31 UTC, Olivier Cochard
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Cochard freebsd_committer 2020-09-28 21:31:18 UTC
Created attachment 218389 [details]
patch to fix build

Patch to fix this error on head:

[00:01:03] ld: error: duplicate symbol: iface
[00:01:03] >>> defined at main.c
[00:01:03] >>>            main.o:(iface)
[00:01:03] >>> defined at iface.c
[00:01:03] >>>            iface.o:(.bss+0x0)
[00:01:03] cc: error: linker command failed with exit code 1 (use -v to see invocation)
[00:01:03] *** [lcdproc] Error code 1
Comment 1 Fernando Apesteguía freebsd_committer 2020-09-30 06:13:45 UTC
^Triage: Reporter is committer, assign accordingly.

Q/A: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.


Thanks!
Comment 2 Olivier Cochard freebsd_committer 2020-09-30 09:16:25 UTC
(In reply to Fernando Apesteguía from comment #1)

I didn't update all the existing patches (that was showing this warning message), I will let the maintainer made his choice about render all of them 'portlint' happy or not :-)
Comment 3 Daniel Shafer 2020-10-01 12:15:52 UTC
Sorry, I've been busy lately.  Quite strange that this problem started occuring.  It worked fine without changes for over a year.  However, has this problem been reported to lcdproc on GitHub?  Is it specific to FreeBSD only perhaps?  There are commits as recent as July 21st this year but the latest release is in 2017, so possible I could release it using the commits until the maintainer decides to do an official release.  I've inquired him on it months ago but never got a real response as to when.
Comment 4 Fernando Apesteguía freebsd_committer 2020-10-01 12:28:35 UTC
(In reply to Daniel Shafer from comment #3)

Hi Daniel,

Both llvm and gcc changed the default for -fcommon and hence the error. Many ports have been affected by this.