Bug 250165 - [exp-run] Replace science/szip with science/libaec
Summary: [exp-run] Replace science/szip with science/libaec
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://people.FreeBSD.org/~sunpoet/p...
Keywords:
Depends on:
Blocks: 228743
  Show dependency treegraph
 
Reported: 2020-10-06 18:45 UTC by Po-Chuan Hsieh
Modified: 2022-07-03 11:04 UTC (History)
1 user (show)

See Also:
antoine: exp-run+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Po-Chuan Hsieh freebsd_committer freebsd_triage 2020-10-06 18:45:35 UTC
Request exp-run.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2020-10-07 09:19:07 UTC
There seems to be less than 50 ports that are affected by this change, can't you test build those ports yourself, or do we really need to build the other 29k ones just to test that change?
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2020-10-15 05:39:16 UTC
Exp-run looks fine,  except for 1 port that was not changed: cad/gmsh
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-06-16 15:15:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=328ae4074233a5b85e0e38efece1af5dcc218160

commit 328ae4074233a5b85e0e38efece1af5dcc218160
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2022-06-16 15:06:54 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-06-16 15:13:01 +0000

    */*: Replace science/szip with science/libaec

    - Bump PORTREVISION of dependent ports for dependency change

    szip does not allow redistribution in binary form without proper commercial
    license. Its LICENSE_PERMS should be set to no-auto-accept which blocks building
    this port, therefore building dependent ports are also blocked. Switch all
    dependent ports to science/libaec to avoid conflicts and license issue.

    PR:             228743, 246097, 250165

 astro/oskar/Makefile             | 3 ++-
 audio/csound/Makefile            | 4 ++--
 biology/kallisto/Makefile        | 3 ++-
 cad/appcsxcad/Makefile           | 3 ++-
 cad/csxcad/Makefile              | 4 ++--
 cad/gmsh/Makefile                | 3 ++-
 graphics/alembic/Makefile        | 3 ++-
 graphics/qgis-ltr/Makefile       | 3 ++-
 graphics/qgis/Makefile           | 3 ++-
 graphics/vigra/Makefile          | 4 ++--
 graphics/vv/Makefile             | 4 ++--
 math/ambit/Makefile              | 3 ++-
 math/armadillo/Makefile          | 3 ++-
 math/flann/Makefile              | 3 ++-
 math/freefem++/Makefile          | 3 ++-
 math/labplot/Makefile            | 4 ++--
 math/mathgl/Makefile             | 4 ++--
 math/mdal/Makefile               | 3 ++-
 math/openturns/Makefile          | 4 ++--
 math/pdal/Makefile               | 4 ++--
 math/saga/Makefile               | 3 ++-
 misc/adios2/Makefile             | 3 ++-
 science/ALPSCore/Makefile        | 4 ++--
 science/InsightToolkit/Makefile  | 4 ++--
 science/abinit/Makefile          | 4 ++--
 science/ascent/Makefile          | 3 ++-
 science/avogadrolibs/Makefile    | 3 ++-
 science/axom/Makefile            | 3 ++-
 science/cdo/Makefile             | 3 ++-
 science/cgnslib/Makefile         | 4 +++-
 science/cgribex/Makefile         | 4 ++--
 science/chemps2/Makefile         | 3 ++-
 science/chrono/Makefile          | 4 ++--
 science/conduit/Makefile         | 3 ++-
 science/dakota/Makefile          | 4 ++--
 science/dynare/Makefile          | 3 ++-
 science/erkale/Makefile          | 3 ++-
 science/gnudatalanguage/Makefile | 4 ++--
 science/hdf/Makefile             | 3 ++-
 science/hdf5-18/Makefile         | 4 ++--
 science/hdf5/Makefile            | 3 ++-
 science/helfem/Makefile          | 4 ++--
 science/lammps/Makefile          | 3 ++-
 science/netcdf/Makefile          | 3 ++-
 science/openems/Makefile         | 4 ++--
 science/openmc/Makefile          | 3 ++-
 science/openmolcas/Makefile      | 3 ++-
 science/py-PyNE/Makefile         | 4 ++--
 science/qmcpack/Makefile         | 4 ++--
 science/rmf/Makefile             | 4 ++--
 science/votca/Makefile           | 4 ++--
 sysutils/slurm-wlm/Makefile      | 3 ++-
 52 files changed, 105 insertions(+), 74 deletions(-)
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-06-16 15:20:32 UTC
Committed. Thanks!
Comment 5 Thierry Thomas freebsd_committer freebsd_triage 2022-07-03 11:04:55 UTC
This commit broke science/paraview but the exp-run did not detect it:

--- VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/CMakeFiles/xdmf2.dir/all ---
--- VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/CMakeFiles/xdmf2.dir/XdmfSet.cxx.o ---
[  3%] Building CXX object VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/CMakeFiles/xdmf2.dir/XdmfSet.cxx.o
cd /wrkdirs/usr/ports/science/paraview/work/.build/VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc && /usr/local/libexec/ccache/c++ -DFreeBSD -DH5_BUILT_AS_DYNAMIC_LIB -DUSE_SERIAL_XMDF -DXDMF_NO_MPI -DXdmf_EXPORTS -D_HPUX_SOURCE -I/wrkdirs/usr/ports/science/paraview/work/ParaView-v5.10.1/VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc -I/wrkdirs/usr/ports/science/paraview/work/.build/VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc -isystem /wrkdirs/usr/ports/science/paraview/work/.build/VTK/ThirdParty/xdmf2 -isystem /wrkdirs/usr/ports/science/paraview/work/ParaView-v5.10.1/VTK/ThirdParty/xdmf2 -isystem /wrkdirs/usr/ports/science/paraview/work/.build/VTK/ThirdParty/hdf5 -isystem /wrkdirs/usr/ports/science/paraview/work/ParaView-v5.10.1/VTK/ThirdParty/hdf5 -isystem /wrkdirs/usr/ports/science/paraview/work/.build/VTK/ThirdParty/libxml2 -isystem /wrkdirs/usr/ports/science/paraview/work/ParaView-v5.10.1/VTK/ThirdParty/libxml2 -isystem /usr/local/include/libxml2 -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -fPIC -std=c++11 -MD -MT VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/CMakeFiles/xdmf2.dir/XdmfSet.cxx.o -MF CMakeFiles/xdmf2.dir/XdmfSet.cxx.o.d -o CMakeFiles/xdmf2.dir/XdmfSet.cxx.o -c /wrkdirs/usr/ports/science/paraview/work/ParaView-v5.10.1/VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfSet.cxx
--- VTK/ThirdParty/exodusII/vtkexodusII/CMakeFiles/exodusII.dir/all ---
/wrkdirs/usr/ports/science/paraview/work/ParaView-v5.10.1/VTK/ThirdParty/exodusII/vtkexodusII/src/ex_utils.c:1773:19: error: expected identifier or '('
        const int NC_SZIP_NN = 32;      /* Selects nearest neighbor coding method for szip. */
                  ^
/usr/local/include/netcdf.h:332:20: note: expanded from macro 'NC_SZIP_NN'
#define NC_SZIP_NN 32 /**< SZIP NN option mask. */
                   ^
1 error generated.
*** [VTK/ThirdParty/exodusII/vtkexodusII/CMakeFiles/exodusII.dir/src/ex_utils.c.o] Error code 1