Bug 250250 - archivers/zstd: zbuff.h includes relative path to zstd.h outside include folder
Summary: archivers/zstd: zbuff.h includes relative path to zstd.h outside include folder
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-10 12:43 UTC by Ted Milker
Modified: 2020-11-16 08:00 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ted Milker 2020-10-10 12:43:23 UTC
zstd adds a zbuff.h header file to /usr/local/include and within this file, there are two lines that look like:

#include "../zstd.h"

on lines 31 and 189.  This doesn't seem correct and when I was building mongodb42-tools with portinstall, I was getting a file not found for zstd.h.  Changing the lines to remove the ../ fixed the compile issue.

I think this is an issue with zstd port but I'm not certain, my C header includes knowledge is really rusty.
Comment 1 dtoch 2020-11-16 08:00:32 UTC
# github.com/mongodb/mongo-tools/vendor/github.com/DataDog/zstd
In file included from vendor/github.com/DataDog/zstd/zstd_stream.go:7:
/usr/local/include/zbuff.h:31:10: error: '../zstd.h' file not found, did you mean 'zstd.h'?
#include "../zstd.h"        /* ZSTD_CStream, ZSTD_DStream, ZSTDLIB_API */
         ^~~~~~~~~~~
         "zstd.h"
1 error generated.

The problem is still here...