Bug 250346 - databases/postgresql13-server: LLVM now disabled entirely
Summary: databases/postgresql13-server: LLVM now disabled entirely
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Palle Girgensohn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-14 15:24 UTC by Christian Ullrich
Modified: 2020-10-21 19:08 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (pgsql)


Attachments
Patch (788 bytes, text/plain)
2020-10-14 15:24 UTC, Christian Ullrich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ullrich 2020-10-14 15:24:10 UTC
Created attachment 218743 [details]
Patch

r551702 disabled LLVM for all platforms in a somewhat roundabout way that makes me think it was not actually intended to apply to anything but powerpc64.

As far as I can tell on boring amd64, the package builds perfectly fine with LLVM, and the result works, so attached is a patch to limit the disabling to powerpc64.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2020-10-14 15:46:48 UTC
^Triage: Cc: committer of r551702.
Comment 2 Palle Girgensohn freebsd_committer 2020-10-14 21:19:18 UTC
Committed. Thanks!
Comment 3 commit-hook freebsd_committer 2020-10-14 21:19:45 UTC
A commit references this bug:

Author: girgen
Date: Wed Oct 14 21:18:57 UTC 2020
New revision: 552356
URL: https://svnweb.freebsd.org/changeset/ports/552356

Log:
  Fix options breakage from r551702.

  Make LLVM option work again on everything but powerpc64.

  PR:		250346
  Submitted by:	Christian Ullrich

Changes:
  head/databases/postgresql13-server/Makefile
Comment 4 commit-hook freebsd_committer 2020-10-21 19:08:04 UTC
A commit references this bug:

Author: pkubaj
Date: Wed Oct 21 19:07:17 UTC 2020
New revision: 552883
URL: https://svnweb.freebsd.org/changeset/ports/552883

Log:
  MFH: r551634 r551663 r551702 r552356

  databases/postgresql13-server: fix build on GCC architectures

  Add the previously removed disabling of LLVM when it's not in base.

  databases/postgresql13-server: fix build on clang architectures

  Move LLVM option configuration after including bsd.port.options.mk.

  Reported by:	kib@

  databases/postgresql13-server: make LLVM option unselectable

  This will still keep this port and its slaves buildable on the package builder on powerpc64, and I doubt anyone uses it on mips*.

  Reported by:	kib@, adamw@

  Fix options breakage from r551702.

  Make LLVM option work again on everything but powerpc64.

  PR:		250346
  Submitted by:	Christian Ullrich

  Approved by:	portmgr (fix build blanket)

Changes:
_U  branches/2020Q4/
  branches/2020Q4/databases/postgresql13-server/Makefile