Bug 250376 - devel/abseil: Should be flavorized to reflect the c++NN level
Summary: devel/abseil: Should be flavorized to reflect the c++NN level
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-15 18:34 UTC by Yuri Victorovich
Modified: 2020-10-15 19:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
patch (474 bytes, patch)
2020-10-15 18:34 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2020-10-15 18:34:28 UTC
Created attachment 218773 [details]
patch

Hello Alexey,

Without -std=c++17 devel/abseil causes dependent port failure, for example math/or-tools (version 8.0) fails to compile. See the suggestion of or-tools' upstream maintainer that abseil needs c++17 here: https://github.com/google/or-tools/issues/2196#issuecomment-707762185


Thank you,
Yuri
Comment 1 Yuri Victorovich freebsd_committer 2020-10-15 19:20:45 UTC
Comment on attachment 218773 [details]
patch

I take back the original patch.

It looks like this port should be flavorized based on the C++ standard used in it, since users seem to be sensitive to this.
Comment 2 Yuri Victorovich freebsd_committer 2020-10-15 19:39:12 UTC
I suggested the upstream to uniquify paths based on CMAKE_CXX_STANDARD: https://github.com/abseil/abseil-cpp/issues/820

Otherwise it wouldn't be possible to update math/or-tools to 8.0.