Bug 250381 - graphics/libosmesa: check-plist fails due to extra files in stage/
Summary: graphics/libosmesa: check-plist fails due to extra files in stage/
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-x11 (Nobody)
Depends on:
Reported: 2020-10-15 23:51 UTC by John Hein
Modified: 2020-10-16 20:22 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)

[patch] don't build & install extra files to stage/ (330 bytes, patch)
2020-10-15 23:51 UTC, John Hein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2020-10-15 23:51:29 UTC
Created attachment 218777 [details]
[patch] don't build & install extra files to stage/

check-plist fails for graphics/libosmesa.  This may have started happening with the switch to meson.

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: include/GL/gl.h
Error: Orphaned: include/GL/glcorearb.h
Error: Orphaned: include/GL/glext.h
Error: Orphaned: include/KHR/khrplatform.h
Error: Orphaned: lib/libglapi.so
Error: Orphaned: lib/libglapi.so.0
Error: Orphaned: lib/libglapi.so.0.0.0
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

The attached patch addresses this by not building / installing files that libosmesa does not need or use.
Comment 1 Niclas Zeising freebsd_committer 2020-10-16 08:09:58 UTC
I can't reproduce this.
I've built libosmesa several times since the meson update, and the package cluster is also fine.  Do you have any special options of any kind?

In any case, I'd want input from manu as well before making changes.
Comment 2 John Hein 2020-10-16 20:22:54 UTC
(In reply to Niclas Zeising from comment #1)
As far as I can see, the package cluster doesn't run the check-plist target?  I think that poudriere bulk -t or testport will run that.  The following log shows that it is not running check-plist (nor stage-qa).


I am not running with anything particularly special.  My poudriere etc/poudriere.d/<jail>/make.conf:


DEVELOPER=yes is ignored by poudriere, so that should be a no-op (see comment above about using bulk -t or testport).  The others shouldn't make a difference for this either, but I have not yet tried a test without them.