Bug 250385 - New port: devel/i3ipc-glib - C interface library to i3wm
Summary: New port: devel/i3ipc-glib - C interface library to i3wm
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-16 01:50 UTC by Robb Randall
Modified: 2021-04-11 19:28 UTC (History)
1 user (show)

See Also:


Attachments
svn diff file (4.14 KB, patch)
2020-10-16 01:50 UTC, Robb Randall
no flags Details | Diff
Added .so file to plist (4.16 KB, patch)
2020-10-16 12:22 UTC, Robb Randall
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robb Randall 2020-10-16 01:50:34 UTC
Created attachment 218780 [details]
svn diff file

i3's interprocess communication (or ipc) is the interface i3wm uses to receive commands from client applications such as i3-msg.
Comment 1 Robb Randall 2020-10-16 12:22:19 UTC
Created attachment 218796 [details]
Added .so file to plist

So sorry, the original pkg-plist did not include the shared object.  I've included it in the second diff file.  Please let me know if you have any questions.

--Robb
Comment 2 Dmitry Marakasov freebsd_committer 2021-02-19 02:01:55 UTC
This has Q/A issues:

====> Running Q/A tests (stage-qa)
Warning: 'lib/libi3ipc-glib-1.0.so.0.0.0' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/libi3ipc-glib-1.0.a
Error: Orphaned: lib/libi3ipc-glib-1.0.so.0
Error: Orphaned: lib/libi3ipc-glib-1.0.so.0.0.0

Also,
- please use USE_GITHUB instead of MASTER_SITES+DISTFILE
- why's ONLY_FOR_ARCHS needed?
- just LICENSE_FILE=
- won't x11-wm be more suitable category?
- please use USES=autoreconf instead of CONFIGURE* and BUILD_DEPENDS=autotools
- please format pkg-descr properly and add WWW
- please don't duplicate depends (json-glib, libxcb).
- please depend on gobject-introspection via USE_GNOME=introspection:build
- please check portlint for other problems, including statement ordering (USES go after depends)
Comment 3 Dmitry Marakasov freebsd_committer 2021-03-09 22:41:12 UTC
Ping?