Bug 250414 - ftp/curl: may automatically pick up libzstd, make that an explicit option
Summary: ftp/curl: may automatically pick up libzstd, make that an explicit option
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-17 09:13 UTC by Matthias Andree
Modified: 2020-10-18 07:39 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
patch to make ZSTD an explicit option to control ./configure behaviour and avoid inconsistency between auto-detection and LIB_DEPENDS (1.46 KB, patch)
2020-10-17 09:13 UTC, Matthias Andree
mandree: maintainer-approval? (sunpoet)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer 2020-10-17 09:13:43 UTC
Created attachment 218835 [details]
patch to make ZSTD an explicit option to control ./configure behaviour and avoid inconsistency between auto-detection and LIB_DEPENDS

curl 7.73 (or generally Curl versions since 2020 August) may, through configure, auto-detect libzstd and then use it. 

I am proposing a patch to control this behaviour explicitly through an option (enabled by default) so as to register the dependency properly and avoid this issue in "env DEVELOPER=yes make -C /usr/ports/ftp/curl stage-qa":

====> Running Q/A tests (stage-qa)
Error: /usr/local/lib/libcurl.so.4.7.0 is linked to /usr/local/lib/libzstd.so.1 from archivers/zstd but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libzstd.so:archivers/zstd

NOTE you may want to bump PORTREVISION to clean this up in existing installs.
Comment 1 dewayne 2020-10-18 07:39:32 UTC
(In reply to Matthias Andree from comment #0)
Thanks Matthias, sorely needed.  I've noticed this behaviour (of picking up zstd) in openssl 1.1.1h on FreeBSD12.2S too.  I had to resequence my port building order to avoid this auto-annoying ;) tendency.