Created attachment 218996 [details]
patch to add asterisk18 flavor
Hi, I just added asterisk18 to the FreeBSD ports tree:
I'm attaching here a patch to add a flavor for it to the asterisk-chan_sccp port, and related conflicts information.
It builds fine, but I'm unable to test it at runtime.
Can approve this change?
@Guido thanks for your patch. I only recently (last week) added support to the autoconf configure script in chan-sccp, so for this patch to work it would also require an update of the source revision (distinfo). Can you include that to the patch, so it will work correctly.
(In reply to Diederik de Groot from comment #1)
Not sure I get what you mean.
Do you have a new release of the module and the ports should be updated to it?
Could you provide a patch?
(In reply to Guido Falsi from comment #2)
Made a release called "v4.3.2-zeta" for you to refer to
I think the 'patch-src_define.h' should no longer be required. Would you mind making these changes and check the compilation.
(In reply to Diederik de Groot from comment #3)
Thanks for the explanation.
I'm going to look into this.
Created attachment 219099 [details]
I created an update patch.
I found a few problems, and I'd rather you have a look.
- build now requires gmake, due to usage of .PHONY targets
- Some include files are missing due to use of pthread functions and S_IRUSR (and friends) defines.
I added the includes to common.h. I think that's fine, but you could want to fix it in your repo.
Does this look fine to you?
(In reply to Guido Falsi from comment #5)
I will update the upstream repo, so that these will no longer be required in the next release. I will have another look, how to prevent the gmake requirement in the Makefile.
Looks fine to me Guido, thanks !
Comment on attachment 219099 [details]
Looks perfectly fine.
Fixed upsteam repo to make your changes official
Fixes the .PHONY issue by including an empty entry for the "force:" case.
If you like i can re-release so the patches are no longer needed or we can re-use the patch as provided above.
(Note the patch provided by Guido, already works)
(In reply to Diederik de Groot from comment #8)
Going to import the patch from the github commit, thanks!
A commit references this bug:
Date: Mon Oct 26 20:58:33 UTC 2020
New revision: 553385
- Update asterisk-chan_sccp to 4.3.2-zeta
- Import upstream patch to fix build
- Add flavor for asterisk18
Approved by: Diederik de Groot <email@example.com> (maintainer)
Update committed. Thanks!
(In reply to Guido Falsi from comment #11)
Thanks Guido and madpilot !