Bug 250573 - archivers/rpm4: 4.16.0 released, please upgrade it ..
Summary: archivers/rpm4: 4.16.0 released, please upgrade it ..
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-24 08:24 UTC by Brian Zou
Modified: 2020-10-26 23:10 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Zou 2020-10-24 08:24:34 UTC
1. remove libdb
2. SQLite 3 as default db
Comment 1 commit-hook freebsd_committer 2020-10-26 10:30:49 UTC
A commit references this bug:

Author: rodrigo
Date: Mon Oct 26 10:30:37 UTC 2020
New revision: 553333
URL: https://svnweb.freebsd.org/changeset/ports/553333

Log:
  archivers/rpm4: Upgrade to 4.16.0

   * Upgrade to 4.16.0
   * add sqlite support
   * remove deprecate config options

  Major changes:
   * Database backends:
     * NDB backend promoted to stable
     * New sqlite-based backend
     * New experimental read-only BDB backend
     * BDB database backend deprecated
   * Powerful macro and %if expressions
   * Optional MIME type based file classification
   * Dependency generation by parametric macros
   * A new version parsing and comparison API in C and Python
   * Parallelise test-suite execution
   * Clarify RPM license

  PR:		250573
  Submitted by:	Brian Zou <zoujiaqing@gmail.com>

Changes:
  head/archivers/rpm4/Makefile
  head/archivers/rpm4/distinfo
  head/archivers/rpm4/files/patch-luaext_lrexlib.c
  head/archivers/rpm4/files/patch-misc_fts.c
  head/archivers/rpm4/files/patch-system.h
  head/archivers/rpm4/pkg-plist
Comment 2 Rodrigo Osorio freebsd_committer 2020-10-26 10:31:42 UTC
Committed, thanks
Comment 3 VVD 2020-10-26 12:12:18 UTC
pkg-plist is broken:

-include/rpm/rpmlib.h
+include/rpm/rpm%%LUA_LIBDIR%%.h

-%%PYTHON%%%%PYTHON_SITELIBDIR%%/rpm/__init__.py
-%%PYTHON%%%%PYTHON_SITELIBDIR%%/rpm/_rpm.so
-%%PYTHON%%%%PYTHON_SITELIBDIR%%/rpm/transaction.py
+%%PYTHON_SITELIBDIR%%/rpm/__init__.py
+%%PYTHON_SITELIBDIR%%/rpm/_rpm.so
+%%PYTHON_SITELIBDIR%%/rpm/transaction.py

-%%PYTHON%%lib/rpm/pythondistdeps.py
+%%LUA_LIBDIR%%/rpm/pythondistdeps.py

-lib/librpm.so
-lib/librpm.so.9
-lib/librpm.so.9.0.1
-lib/librpmbuild.so
-lib/librpmbuild.so.9
-lib/librpmbuild.so.9.0.1
-lib/librpmio.so
-lib/librpmio.so.9
-lib/librpmio.so.9.0.1
-lib/librpmsign.so
-lib/librpmsign.so.9
-lib/librpmsign.so.9.0.1
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpm.so
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpm.so.9
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpm.so.9.1.0
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpmbuild.so
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpmbuild.so.9
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpmbuild.so.9.1.0
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpmio.so
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpmio.so.9
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpmio.so.9.1.0
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpmsign.so
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpmsign.so.9
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpmsign.so.9.1.0
Comment 4 Rodrigo Osorio freebsd_committer 2020-10-26 12:29:38 UTC
(In reply to VVD from comment #3)

I'm sorry but AFAIK, no breakage
was reported by poudriere testport.
How do you spot such breakage ?
Comment 5 VVD 2020-10-26 14:03:51 UTC
(In reply to Rodrigo Osorio from comment #4)
Try to build with PYTHON off, for example.

And how this can be correct?
-include/rpm/rpmlib.h
+include/rpm/rpm%%LUA_LIBDIR%%.h

-lib/librpm.so
+%%LUA_LIBDIR%%/%%LUA_LIBDIR%%rpm.so

All substrings "lib" was replaced with "%%LUA_LIBDIR%%" - why???
Comment 6 Rodrigo Osorio freebsd_committer 2020-10-26 18:43:05 UTC
(In reply to VVD from comment #5)
Ok, I didn't test all options combination, sorry for that.
Comment 7 commit-hook freebsd_committer 2020-10-26 21:51:03 UTC
A commit references this bug:

Author: rodrigo
Date: Mon Oct 26 21:50:59 UTC 2020
New revision: 553390
URL: https://svnweb.freebsd.org/changeset/ports/553390

Log:
  Fix plist when PYTHON option is disabled

  Bump portrevision

  PR:		250573
  Reported by:	VVD <vvd@unislabs.com>

Changes:
  head/archivers/rpm4/Makefile
  head/archivers/rpm4/pkg-plist
Comment 8 Rodrigo Osorio freebsd_committer 2020-10-26 21:52:01 UTC
plist fixed, thanks for the heads-up
Comment 9 VVD 2020-10-26 23:10:27 UTC
(In reply to Rodrigo Osorio from comment #8)
Thanks.

But anyway replace all sub-stings "lib" with "%%LUA_LIBDIR%%" look very strange for me…