Bug 250595 - devel/hyperscan: update 5.2.1 -> 5.3.2
Summary: devel/hyperscan: update 5.2.1 -> 5.3.2
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vsevolod Stakhov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-25 16:10 UTC by Kurt Jaeger
Modified: 2021-04-28 10:51 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (vsevolod)


Attachments
patch (998 bytes, patch)
2020-10-25 16:10 UTC, Kurt Jaeger
no flags Details | Diff
patch (2.54 KB, patch)
2020-12-31 16:45 UTC, Kurt Jaeger
no flags Details | Diff
Build log (failed) on arm64 (46.80 KB, text/plain)
2021-01-07 18:21 UTC, Daniel Engberg
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer 2020-10-25 16:10:52 UTC
Created attachment 219064 [details]
patch

RelNotes: https://github.com/intel/hyperscan/releases/tag/v5.3.0
Comment 1 Daniel Engberg freebsd_committer 2020-10-25 20:32:47 UTC
Is it possible to bump boost to 1.74.0 to match upcoming version in tree?
https://reviews.freebsd.org/D24485

While I understand that maintaining external patches isn't ideal it might be of interest to possibly import (aarch64 support) https://github.com/MarvellEmbeddedProcessors/hyperscan/commits/master

Unfortunately upstream doesn't seem to be too keen about the idea :(
https://github.com/intel/hyperscan/issues/197
Comment 2 Daniel Engberg freebsd_committer 2020-12-31 15:59:05 UTC
https://www.vectorcamp.gr/2020/05/09/we-are-thrilled-to-announce-our-first-customer/

fwiw, Alpine Linux uses their fork now
Comment 3 Kurt Jaeger freebsd_committer 2020-12-31 16:29:43 UTC
(In reply to daniel.engberg.lists from comment #1)

Using the patch with

Patching file src/util#PATCH_SITES=   https://github.com/MarvellEmbeddedProcessors/${GH_PROJECT}/commit/
#PATCHFILES=    8a786129edb297285820ee1963de2472e38ea820.patch:-p1

fails with this:

Patching file src/util/simd_utils.h using Plan A...
Hunk #1 succeeded at 33.
Hunk #2 failed at 73.
Hunk #3 failed at 81.
2 out of 3 hunks failed--saving rejects to src/util/simd_utils.h.rej
Comment 4 Kurt Jaeger freebsd_committer 2020-12-31 16:33:31 UTC
(In reply to daniel.engberg.lists from comment #2)
Ah, now I get it. VectorCamp has a fork 5.3.2, where the patch is
already included.
Comment 5 Daniel Engberg freebsd_committer 2020-12-31 16:40:35 UTC
Indeed, here's how Alpine does it (in case it helps)
https://git.alpinelinux.org/aports/tree/community/hyperscan/APKBUILD
Comment 6 Kurt Jaeger freebsd_committer 2020-12-31 16:45:03 UTC
Created attachment 221141 [details]
patch

testbuild on 13 is ok
Comment 7 Kurt Jaeger freebsd_committer 2020-12-31 16:46:38 UTC
and changing upstream from intel to VectorCamp as suggested
Comment 8 Kurt Jaeger freebsd_committer 2020-12-31 18:43:31 UTC
(In reply to daniel.engberg.lists from comment #5)
5.3.2 builds, just not on aarch64 8-(

https://people.freebsd.org/~pi/logs/hyperscan-5.3.2.log
Comment 9 Daniel Engberg freebsd_committer 2021-01-07 18:21:07 UTC
Created attachment 221362 [details]
Build log (failed) on arm64

https://github.com/VectorCamp/hyperscan/blob/v5.3.2/CMakeLists.txt#L247
https://github.com/VectorCamp/hyperscan/blob/v5.3.2/CMakeLists.txt#L251
Needs to be removed or at least changed as native doesn't work on aarch64 but it still fails to build :/
Comment 10 Vsevolod Stakhov freebsd_committer 2021-01-07 18:25:51 UTC
I don't have aarch64 with FreeBSD to test :( I will try to ask br@ as he definitely has one (or more).
Comment 11 Kurt Jaeger freebsd_committer 2021-01-07 23:11:23 UTC
(In reply to Vsevolod Stakhov from comment #10)

With the suggested modification for CMakeLists.txt, it gets over the
initial problem, but fails at some other part:

https://people.freebsd.org/~pi/logs/hyperscan-arm-v2.txt
Comment 12 Daniel Engberg freebsd_committer 2021-01-27 00:30:13 UTC
I guess we could create a new port as they've decided to change the name
https://github.com/VectorCamp/vectorscan/releases/tag/vectorscan-v5.4.0

fwiw, compiles using GCC on 13-CURRENT (aarch64)
Comment 13 Daniel Engberg freebsd_committer 2021-04-28 10:51:22 UTC
Vsevolod

Could you consider adoptiong vectorscan instead so we could also bring support to arm64 and eventually Power too?