Bug 250620 - www/osrm-backend: Update to v5.23.0
Summary: www/osrm-backend: Update to v5.23.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/Project-OSRM/osrm-...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-10-26 03:06 UTC by Peter Laursen
Modified: 2020-11-03 14:21 UTC (History)
1 user (show)

See Also:
fernape: merge-quarterly+


Attachments
Patch to update port (2.99 KB, patch)
2020-10-26 03:06 UTC, Peter Laursen
freebsd: maintainer-approval+
Details | Diff
osrm upgrade patch (v2), fixes build and removes stale dependencies (4.06 KB, patch)
2020-11-03 05:50 UTC, Peter Laursen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Laursen 2020-10-26 03:06:01 UTC
Created attachment 219089 [details]
Patch to update port

Hi,
Attached is a patch that updates www/osrm-backend to v5.23.0.
This update also fixes recent build errors as seen on the current version.

All the best,

Peter.
Comment 1 Fernando Apesteguía freebsd_committer 2020-10-26 07:44:17 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

It seems to fail in 11 so we should MFH this.

Thanks!
Comment 2 Peter Laursen 2020-10-26 14:54:33 UTC
Hi,
Thanks for the feedback.
I have added the Github Tag URL as that contains the changes.

All the best,

Peter.
Comment 3 Fernando Apesteguía freebsd_committer 2020-10-26 16:26:29 UTC
It does not build in 11:

/wrkdirs/usr/ports/www/osrm-backend/work/osrm-backend-5.23.0/src/util/timezones.cpp:157:21: error: loop variable 'v' of type 'const std::__1::pair<boost::geometry::model::box<boos
t::geometry::model::point<double, 2, boost::geometry::cs::spherical_equatorial<boost::geometry::degree> > >, unsigned long>' creates a copy from type 'const std::__1::pair<boost::
geometry::model::box<boost::geometry::model::point<double, 2, boost::geometry::cs::spherical_equatorial<boost::geometry::degree> > >, unsigned long>' [-Werror,-Wrange-loop-constru
ct]
    for (const auto v : result)
                    ^
/wrkdirs/usr/ports/www/osrm-backend/work/osrm-backend-5.23.0/src/util/timezones.cpp:157:10: note: use reference type 'const std::__1::pair<boost::geometry::model::box<boost::geome
try::model::point<double, 2, boost::geometry::cs::spherical_equatorial<boost::geometry::degree> > >, unsigned long> &' to prevent copying
    for (const auto v : result)
         ^~~~~~~~~~~~~~
                    &

Would it work with a patch with the suggested fix?

In 12 and 13 it also fails :-( in this case with:

===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: etc/rc.d/osrm
Comment 4 Peter Laursen 2020-11-03 05:50:13 UTC
Created attachment 219318 [details]
osrm upgrade patch (v2), fixes build and removes stale dependencies

Hi,
Sorry for the bad patch.
This patch should fix builds on 11 and 12 and update to the latest version.

All the best,

Peter
Comment 5 commit-hook freebsd_committer 2020-11-03 14:18:30 UTC
A commit references this bug:

Author: fernape
Date: Tue Nov  3 14:17:55 UTC 2020
New revision: 553984
URL: https://svnweb.freebsd.org/changeset/ports/553984

Log:
  www/osrm-backend: Update to v5.23.0

  ChangeLog: https://github.com/Project-OSRM/osrm-backend/releases/tag/v5.23.0

  PR:	250620
  Submitted by:	freebsd@mosedal.net (maintainer)
  MFH:	2020Q4 (blanket, runtime fixes)

Changes:
  head/www/osrm-backend/Makefile
  head/www/osrm-backend/distinfo
  head/www/osrm-backend/files/patch-src_util_timezones.cpp
  head/www/osrm-backend/pkg-plist
Comment 6 commit-hook freebsd_committer 2020-11-03 14:20:32 UTC
A commit references this bug:

Author: fernape
Date: Tue Nov  3 14:20:00 UTC 2020
New revision: 553985
URL: https://svnweb.freebsd.org/changeset/ports/553985

Log:
  MFH: r553984

  www/osrm-backend: Update to v5.23.0

  ChangeLog: https://github.com/Project-OSRM/osrm-backend/releases/tag/v5.23.0

  PR:	250620
  Submitted by:	freebsd@mosedal.net (maintainer)

  Approved by:	ports-secteam (blanket, runtime fixes)

Changes:
_U  branches/2020Q4/
  branches/2020Q4/www/osrm-backend/Makefile
  branches/2020Q4/www/osrm-backend/distinfo
  branches/2020Q4/www/osrm-backend/files/patch-src_util_timezones.cpp
  branches/2020Q4/www/osrm-backend/pkg-plist
Comment 7 Fernando Apesteguía freebsd_committer 2020-11-03 14:21:20 UTC
Committed and MFHed.

Thanks!