Bug 250683 - usbhidaction(1) man page example incongruence
Summary: usbhidaction(1) man page example incongruence
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-28 06:26 UTC by corvid
Modified: 2020-11-11 11:27 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description corvid 2020-10-28 06:26:44 UTC
The example gives Consumer:Volume_Down and Consumer:Volume_Up, but when I look in the mentioned /usr/share/misc/usb_hid_usages under Consumer, they are listed as Volume_Decrement and Volume_Increment.
Comment 1 Mateusz Piotrowski freebsd_committer 2020-10-28 08:18:23 UTC
I confirm that this is incorrect ("awk '/^[0-9]+/{print} /Volume/{print}' /usr/share/misc/usb_hid_usages" shows that Consumer only has "Volume", "Volume Increment", and "Volume Decrement").
Comment 2 commit-hook freebsd_committer 2020-10-28 08:29:36 UTC
A commit references this bug:

Author: 0mp
Date: Wed Oct 28 08:29:32 UTC 2020
New revision: 367097
URL: https://svnweb.freebsd.org/changeset/base/367097

Log:
  Correct USB HID item in examples

  It turns out that examples were incorrectly referring to Volume_Up
  and Volume_Down, which are not defined at all.

  PR:		250683
  Reported by:	corvid%openmailbox.org
  MFC after:	2 weeks

Changes:
  head/usr.bin/usbhidaction/usbhidaction.1
Comment 3 Mateusz Piotrowski freebsd_committer 2020-10-28 08:33:28 UTC
Thanks!
Comment 4 commit-hook freebsd_committer 2020-11-11 11:25:30 UTC
A commit references this bug:

Author: 0mp
Date: Wed Nov 11 11:25:15 UTC 2020
New revision: 367586
URL: https://svnweb.freebsd.org/changeset/base/367586

Log:
  MFC r367097:

  Correct USB HID item in examples

  It turns out that examples were incorrectly referring to Volume_Up
  and Volume_Down, which are not defined at all.

  PR:		250683

Changes:
_U  stable/12/
  stable/12/usr.bin/usbhidaction/usbhidaction.1
Comment 5 commit-hook freebsd_committer 2020-11-11 11:27:31 UTC
A commit references this bug:

Author: 0mp
Date: Wed Nov 11 11:26:37 UTC 2020
New revision: 367587
URL: https://svnweb.freebsd.org/changeset/base/367587

Log:
  MFC r367097:

  Correct USB HID item in examples

  It turns out that examples were incorrectly referring to Volume_Up
  and Volume_Down, which are not defined at all.

  PR:		250683

Changes:
_U  stable/11/
  stable/11/usr.bin/usbhidaction/usbhidaction.1