Bug 250692 - freebsd 12.2 - "zpool list -v" output alignment broken
Summary: freebsd 12.2 - "zpool list -v" output alignment broken
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 12.2-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-10-28 12:04 UTC by elij
Modified: 2021-04-16 23:38 UTC (History)
1 user (show)

See Also:


Attachments
example alignment issue (378 bytes, text/plain)
2020-10-28 12:04 UTC, elij
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description elij 2020-10-28 12:04:15 UTC
Created attachment 219168 [details]
example alignment issue

In FreeBSD-12.2R the "zpool list -v" alignment is weird. It seems to align each pool individually, but not across pools. The output was aligned more correctly with FreeBSD-12.1.

Example output attached.
Comment 1 elij 2021-04-13 21:18:34 UTC
Issue still present in freebsd 13.0-RELEASE.
Comment 2 Yuri Pankov freebsd_committer 2021-04-13 22:37:52 UTC
Can you provide the output from 13.0-RELEASE?  I have noticed only the following issue with per-vdev health: https://github.com/openzfs/zfs/pull/11899.
Comment 3 elij 2021-04-13 22:50:18 UTC
Yuri, it does at first look indeed seem like the issue is now limited to per-vdev health, whereas before it was much much worse. Great news indeed!

Output from a system with FreeBSD-13.0:

NAME        SIZE  ALLOC   FREE  CKPOINT  EXPANDSZ   FRAG    CAP  DEDUP    HEALTH  ALTROOT
zbuild      464G   137G   327G        -         -     5%    29%  1.00x    ONLINE  -
  nvd0      464G   137G   327G        -         -     5%  29.5%      -  ONLINE  
zroot       228G  3.73G   224G        -         -     2%     1%  1.00x    ONLINE  -
  ada0p4    228G  3.73G   224G        -         -     2%  1.63%      -  ONLINE  

I do have a different system with two pools with vdevs with very different lengths, which I haven't yet upgraded. Here is an example of the FreeBSD 12.2 output from that system for a comparison:

NAME                       SIZE  ALLOC   FREE  CKPOINT  EXPANDSZ   FRAG    CAP  DEDUP  HEALTH  ALTROOT
zbackup                   10.9T  6.34T  4.54T        -         -     0%    58%  1.00x  ONLINE  -
  mirror                  10.9T  6.34T  4.54T        -         -     0%  58.3%
    diskid/DISK-ZHZ3S3P3      -      -      -        -         -      -      -
    diskid/DISK-ZHZ3RSW3      -      -      -        -         -      -      -
zsys              464G  2.35G   462G        -         -     0%     0%  1.00x  ONLINE  -
  mirror          464G  2.35G   462G        -         -     0%  0.50%
    gpt/zroot-0      -      -      -        -         -      -      -
    gpt/zroot-1      -      -      -        -         -      -      -
Comment 4 elij 2021-04-16 23:16:13 UTC
Finally got around to upgrading the freebsd 12.2 system with many vdevs with a variety of name lengths, to freebsd 13.0.

Confirmed that only the health column is misaligned now. Great!
Comment 5 Yuri Pankov freebsd_committer 2021-04-16 23:38:54 UTC
The PR I mentioned above is merged in openzfs, though I am not sure if/when it will be merged to stable/13.