Bug 250829 - games/devilutionX: remove WITH_DEBUG option
Summary: games/devilutionX: remove WITH_DEBUG option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-03 13:19 UTC by Nuno Teixeira
Modified: 2020-11-26 07:58 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (benny.goemans)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira 2020-11-03 13:19:45 UTC 
Hello,

Sugestion to remove WITH_DEBUG port option because, IMO:

- do we need debug option on a release that is stable? (I killed Diablo about 12 times without issues)

- if we do need DEBUG option then correct cmake NIGHTLY_BUILD with DEBUG option (accordingly with https://github.com/diasurgical/devilutionX/issues/908 ).

What do you think?

Thanks,

Nuno Teixeira
Comment 1 Nuno Teixeira 2020-11-03 13:22:41 UTC 
PS: ... and to simplify port.
Comment 2 malavon 2020-11-24 15:28:53 UTC 
To be fair, I only visit this port once in a while. Back when I ported it I assumed there might be some benefit to using it. I'll try to dig deeper into it, but I'm currently working on other things that have priority over pretty much anything else.

That said, I have the feeling that you are quite interested in this port. Could I interest you in taking over maintainership?
Comment 3 Nuno Teixeira 2020-11-25 07:39:36 UTC 
(In reply to malavon from comment #2)
Hello!

Yes, I can take maintainership on this port.

Should I send a Bug Report?

Thanks,

Nuno Teixeira
Comment 4 malavon 2020-11-25 11:32:23 UTC 
Yep, go ahead and I'll approve.
Comment 5 Nuno Teixeira 2020-11-26 07:58:12 UTC 
(In reply to malavon from comment #4)

Bug 251397 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251397

I will close this one.

Thanks