Bug 250832 - graphics/evince: Update to 3.38.0
Summary: graphics/evince: Update to 3.38.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
Depends on:
Reported: 2020-11-03 15:57 UTC by Neel Chauhan
Modified: 2020-12-08 09:15 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+

Patch (Revision 1) (1.80 KB, patch)
2020-11-03 15:57 UTC, Neel Chauhan
no flags Details | Diff
Patch (Revision 2) (7.97 KB, patch)
2020-11-07 17:58 UTC, Neel Chauhan
no flags Details | Diff
Patch (Revision 3) (5.31 KB, patch)
2020-11-15 22:37 UTC, Neel Chauhan
no flags Details | Diff
Patch (Revision 4) (5.19 KB, patch)
2020-11-21 21:22 UTC, Neel Chauhan
no flags Details | Diff
Patch (Revision 5) (3.10 KB, patch)
2020-12-04 19:41 UTC, Neel Chauhan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer 2020-11-03 15:57:08 UTC
Created attachment 219324 [details]
Patch (Revision 1)

Passes poudriere.
Comment 1 Tobias C. Berner freebsd_committer 2020-11-07 10:06:28 UTC
Moin moin 

This one requires some more work.

mfg Tobias

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: include/evince/%%VERSION%%/libdocument/ev-form-field-private.h
Error: Orphaned: man/man1/evince-previewer.1.gz
Error: Orphaned: man/man1/evince-thumbnailer.1.gz
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

make: stopped in /usr/ports/graphics/evince
=>> Error: check-plist failures detected
=>> Cleaning up wrkdir
===>  Cleaning for evince-lite-3.38.0
Comment 2 Neel Chauhan freebsd_committer 2020-11-07 17:58:05 UTC
Created attachment 219432 [details]
Patch (Revision 2)
Comment 3 Tobias C. Berner freebsd_committer 2020-11-15 10:10:33 UTC
Moin moin 

You dropped the options-subs in the plist -- this needs to be corrected.

mfg Tobias
Comment 4 Neel Chauhan freebsd_committer 2020-11-15 22:37:27 UTC
Created attachment 219716 [details]
Patch (Revision 3)

Here's an updated patch.
Comment 5 Tobias C. Berner freebsd_committer 2020-11-21 18:41:46 UTC

this looks wrong :)
Comment 6 Neel Chauhan freebsd_committer 2020-11-21 21:22:18 UTC
Created attachment 219868 [details]
Patch (Revision 4)
Comment 7 Tobias C. Berner freebsd_committer 2020-12-04 19:33:08 UTC
Moin moin

There still seems to be dropped plist items from options -- are they really not installed anymore?

Could you please double check and make sure?

Using `poudriere  -j<yourjail> -cn -p<yourtree> graphics/evince` you can set the options and double chekck.

mfg Tobias
Comment 8 Neel Chauhan freebsd_committer 2020-12-04 19:41:16 UTC
Created attachment 220261 [details]
Patch (Revision 5)

Fixed the plist.
Comment 9 Tobias C. Berner freebsd_committer 2020-12-08 08:34:14 UTC
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: share/metainfo/evince-djvudocument.metainfo.xml

try again :P
Comment 10 Tobias C. Berner freebsd_committer 2020-12-08 08:38:42 UTC
(In reply to Tobias C. Berner from comment #9)
[note that was for the lite flavor]
Comment 11 commit-hook freebsd_committer 2020-12-08 09:15:19 UTC
A commit references this bug:

Author: tcberner
Date: Tue Dec  8 09:14:49 UTC 2020
New revision: 557265
URL: https://svnweb.freebsd.org/changeset/ports/557265

  graphics/evince: update to 3.38.0

  PR:		250832
  Submitted by:	Neel Chauhan <neel@neelc.org>