Bug 251136 - x11-wm/xfce4-wm: 4.14.6 fix crash on hang application kill via context menu
Summary: x11-wm/xfce4-wm: 4.14.6 fix crash on hang application kill via context menu
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-xfce (Nobody)
URL: https://gitlab.xfce.org/xfce/xfwm4/-/...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-14 15:09 UTC by rozhuk.im
Modified: 2020-11-15 13:18 UTC (History)
3 users (show)

See Also:
madpilot: maintainer-feedback+


Attachments
patch (1.16 KB, patch)
2020-11-14 15:09 UTC, rozhuk.im
rozhuk.im: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rozhuk.im 2020-11-14 15:09:23 UTC
Created attachment 219680 [details]
patch

If I try to kill/end hanged app via context menu then after app die xfwm4 core dumps:

/usr/local/bin/xfwm4 --display unix:0.0 --sm-client-id 2d88326ee-d7fc-11e5-8d34-6cf0497538e3 --replace
Waiting for current window manager (Xfwm4) on screen unix:0.0 to exit: Done

(xfwm4:9573): Gdk-ERROR **: 17:39:45.446: The program 'xfwm4' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadValue (integer parameter out of range for operation)'.
  (Details: serial 78074 error_code 2 request_code 113 (core protocol) minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the GDK_SYNCHRONIZE environment
   variable to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
Trace/BPT trap (core dumped)
Comment 1 Guido Falsi freebsd_committer 2020-11-14 19:21:02 UTC
Thanks for reporting this.

I see upstream already committed a patch, so I'll see to include it in the port in the near future.
Comment 2 commit-hook freebsd_committer 2020-11-15 12:26:29 UTC
A commit references this bug:

Author: madpilot
Date: Sun Nov 15 12:25:31 UTC 2020
New revision: 555201
URL: https://svnweb.freebsd.org/changeset/ports/555201

Log:
  Import upstream patch to avoid crash due to unhandled XError in
  XKillClient()

  PR:		251136
  Submitted by:	rozhuk.im@gmail.com
  Obtained from:	https://gitlab.xfce.org/xfce/xfwm4/-/commit/e2fbfac304beace0297d071f7de0aceba4f0016a
  MFH:		2020Q4

Changes:
  head/x11-wm/xfce4-wm/Makefile
  head/x11-wm/xfce4-wm/files/
  head/x11-wm/xfce4-wm/files/patch-XKillClient-XError
Comment 3 Guido Falsi freebsd_committer 2020-11-15 12:27:43 UTC
Committed, will also merge to quarterly.

Thanks!
Comment 4 commit-hook freebsd_committer 2020-11-15 13:18:36 UTC
A commit references this bug:

Author: madpilot
Date: Sun Nov 15 13:18:25 UTC 2020
New revision: 555211
URL: https://svnweb.freebsd.org/changeset/ports/555211

Log:
  MFH: r553863 r555201

  Update xfce4-wm to 4.14.6

  Import upstream patch to avoid crash due to unhandled XError in
  XKillClient()

  PR:		251136
  Submitted by:	rozhuk.im@gmail.com
  Obtained from:	https://gitlab.xfce.org/xfce/xfwm4/-/commit/e2fbfac304beace0297d071f7de0aceba4f0016a

  Approved by:	ports-secteam (riggs, fluffy)

Changes:
_U  branches/2020Q4/
  branches/2020Q4/x11-wm/xfce4-wm/Makefile
  branches/2020Q4/x11-wm/xfce4-wm/distinfo
  branches/2020Q4/x11-wm/xfce4-wm/files/