Bug 251160 - security/botan2: fix build on arm
Summary: security/botan2: fix build on arm
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-15 16:37 UTC by Mikael Urankar
Modified: 2020-11-16 10:21 UTC (History)
2 users (show)

See Also:
tremere: maintainer-feedback+


Attachments
v1 (1.20 KB, patch)
2020-11-15 16:37 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer 2020-11-15 16:37:21 UTC
Created attachment 219703 [details]
v1

from a quick glance, processor_rng seems to be only implemented on x86 and powerpc64

===>  Building package for botan2-2.17.1
pkg-static: Unable to access file /wrkdirs/usr/ports/security/botan2/work/stage/usr/local/include/botan-2/botan/processor_rng.h:No such file or directory
Comment 1 Ralf van der Enden 2020-11-15 20:05:32 UTC
(In reply to Mikael Urankar from comment #0)

Hi mikael,

Are lines 74 and 77 necessary, as those are set in the second .if/.else/.endif block as well ?

Other than that the patch looks fine.
Comment 2 Mikael Urankar freebsd_committer 2020-11-16 10:21:42 UTC
(In reply to Ralf van der Enden from comment #1)
Comment 3 commit-hook freebsd_committer 2020-11-16 10:21:46 UTC
A commit references this bug:

Author: mikael
Date: Mon Nov 16 10:21:25 UTC 2020
New revision: 555460
URL: https://svnweb.freebsd.org/changeset/ports/555460

Log:
  security/botan2: fix build on arm

  processor_rng is only implemented on x86 and powerpc64

  PR:		251160
  Approved by:	Ralf van der Enden (maintainer)

Changes:
  head/security/botan2/Makefile
  head/security/botan2/pkg-plist