Bug 251222 - x11-fonts/libXft: add bgra (color emoji support) patch
Summary: x11-fonts/libXft: add bgra (color emoji support) patch
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-17 23:35 UTC by Yuri Pankov
Modified: 2020-11-18 10:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (desktop)


Attachments
bgra patch (23.35 KB, text/plain)
2020-11-17 23:35 UTC, Yuri Pankov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Pankov 2020-11-17 23:35:24 UTC
Created attachment 219776 [details]
bgra patch

Add a patch from https://aur.archlinux.org/packages/libxft-bgra/ allowing for color emoji support.  Patch is taken as is from https://gitlab.freedesktop.org/xorg/lib/libxft/-/commit/7808631e7a9a605d5fe7a1077129c658d9ec47fc.patch and renamed to follow other extra patch names in ports.  Tested with x11/sterm.
Comment 1 Niclas Zeising freebsd_committer 2020-11-18 09:13:13 UTC
The review for inclusion in libXft is still on-going.  Isn't it better to wait until it's actually committed upstream?
Comment 2 Yuri Pankov 2020-11-18 09:30:11 UTC
(In reply to Niclas Zeising from comment #1)
I'm just trying to get this in as other "distributions" did in the mean time as from reading the whole thread, it looks the delay isn't in reviewing the code itself (it was said to be OK on several occasions), rather deciding if it should be done in libXrender (that is, new xorg-server release, when?) or libXft way (also, when?).  Having the turned off by default patch would help those who's asking for it now.
Comment 3 Niclas Zeising freebsd_committer 2020-11-18 09:55:56 UTC
Which other distributions?

If there's discussions about where to put the functionality, it is not ready in my opinion.

libXrender is a separate package, but perhaps there is need for support in xserver as well.

That said, I'm not the final authority on this, if other maintainers feel this is ok to add, then I'm OK with it.
Comment 4 Yuri Pankov 2020-11-18 10:05:09 UTC
(In reply to Niclas Zeising from comment #3)
> Which other distributions?

I mean various linuxes, integrating the patch for those who want it.

> If there's discussions about where to put the functionality, it is not ready in my opinion.

And that's why it's just an option, and off by default, so it can be dropped any time when decision upstream is made without affecting anyone.

> libXrender is a separate package, but perhaps there is need for support in xserver as well.

Looks like that is the case from reading https://gitlab.freedesktop.org/xorg/lib/libxft/-/merge_requests/1#note_654920.

> That said, I'm not the final authority on this, if other maintainers feel this is ok to add, then I'm OK with it.

Got it.