Created attachment 219776 [details]
Add a patch from https://aur.archlinux.org/packages/libxft-bgra/ allowing for color emoji support. Patch is taken as is from https://gitlab.freedesktop.org/xorg/lib/libxft/-/commit/7808631e7a9a605d5fe7a1077129c658d9ec47fc.patch and renamed to follow other extra patch names in ports. Tested with x11/sterm.
The review for inclusion in libXft is still on-going. Isn't it better to wait until it's actually committed upstream?
(In reply to Niclas Zeising from comment #1)
I'm just trying to get this in as other "distributions" did in the mean time as from reading the whole thread, it looks the delay isn't in reviewing the code itself (it was said to be OK on several occasions), rather deciding if it should be done in libXrender (that is, new xorg-server release, when?) or libXft way (also, when?). Having the turned off by default patch would help those who's asking for it now.
Which other distributions?
If there's discussions about where to put the functionality, it is not ready in my opinion.
libXrender is a separate package, but perhaps there is need for support in xserver as well.
That said, I'm not the final authority on this, if other maintainers feel this is ok to add, then I'm OK with it.
(In reply to Niclas Zeising from comment #3)
> Which other distributions?
I mean various linuxes, integrating the patch for those who want it.
> If there's discussions about where to put the functionality, it is not ready in my opinion.
And that's why it's just an option, and off by default, so it can be dropped any time when decision upstream is made without affecting anyone.
> libXrender is a separate package, but perhaps there is need for support in xserver as well.
Looks like that is the case from reading https://gitlab.freedesktop.org/xorg/lib/libxft/-/merge_requests/1#note_654920.
> That said, I'm not the final authority on this, if other maintainers feel this is ok to add, then I'm OK with it.
There's an ongoing -- slow -- conversation in the upstream merge-request, https://gitlab.freedesktop.org/xorg/lib/libxft/-/merge_requests/1 , so let's wait until it is resolved there. There seems to be progress, but no clear-cut "this is it" yet.
The comments in the GitLab thread about this wander all over the place:
- Keith says it's ok, or at least good enough to merge to his forks,
- Keith says there's some interesting work to do elsewhere,
- There's a new libXft release without this code.
Then there's also a ton of comments about "this crashes" and "now it's fucked" which .. doesn't fill me with confidence. This isn't something I have time to test extensively, so I'm going to once again let it rest.
I see upstream that Xft 2.3.5 merged a modified form of the BGRA patch, and we're at 2.3.7 in ports so I'm going to close this PR as "handled upstream".