Bug 251256 - net/concourse-fly: switch to USES=go:modules, cleanup
Summary: net/concourse-fly: switch to USES=go:modules, cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jean-Sébastien Pédron
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-19 15:48 UTC by Dmitri Goutnik
Modified: 2020-11-20 09:21 UTC (History)
0 users

See Also:
dumbbell: maintainer-feedback+
dmgk: maintainer-feedback?

Attachments
patch file (1.31 KB, patch)
2020-11-19 15:48 UTC, Dmitri Goutnik 		dmgk: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2020-11-19 15:48:36 UTC 
Created attachment 219813 [details]
patch file

Properly switch to USES=go:modules and do some cleanup in preparation for the upcoming go1.16 release.

Builds fine on 12.2-RELEASE amd64 with both current lang/go 1.15.5 and lang/go-devel@399b5d14d411
Comment 1 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2020-11-19 20:50:04 UTC 
Thank you for the patch!

I will test it tonight.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-11-20 09:19:50 UTC 
A commit references this bug:

Author: dumbbell
Date: Fri Nov 20 09:19:30 UTC 2020
New revision: 555753
URL: https://svnweb.freebsd.org/changeset/ports/555753

Log:
  net/concourse-fly: Update to 6.7.1

  `patch-vendor_golang.org_x_sys_unix_ztypes__freebsd__arm64.go` is removed
  because it was integrated upstream.

  Thanks to dmgk@, the Makefile is switched to use USES=go:modules and cleaned up
  in preparation for the upcoming Go 1.16 release; see PR 251256 [1].

  PR:		251256
  Submitted by:	dmgk@ [1]

Changes:
  head/net/concourse-fly/Makefile
  head/net/concourse-fly/distinfo
  head/net/concourse-fly/files/patch-vendor_golang.org_x_sys_unix_ztypes__freebsd__arm64.go
Comment 3 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2020-11-20 09:21:04 UTC 
Committed, thank you!