Bug 251371 - irc/irssi: building 1.3.d.344,1 breaks when PERL=OFF
Summary: irc/irssi: building 1.3.d.344,1 breaks when PERL=OFF
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-25 09:43 UTC by Michael Bueker
Modified: 2020-11-26 08:47 UTC (History)
3 users (show)

See Also:
dor.bsd: maintainer-feedback+


Attachments
poudriere log with failure (20.21 KB, text/plain)
2020-11-25 09:43 UTC, Michael Bueker
no flags Details
irc/irssi: Port always uses perl5 (629 bytes, patch)
2020-11-25 23:03 UTC, David O'Rourke
dor.bsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Bueker 2020-11-25 09:43:00 UTC
Created attachment 219956 [details]
poudriere log with failure

With PERL unselected, irssi no longer builds in poudriere (see attached log), failing with the message:

meson.build:75:0: ERROR: Program 'perl' not found
Comment 1 David O'Rourke 2020-11-25 12:25:59 UTC
Thanks for this report.

It looks like Perl is required during the build, even if you aren't compiling support for Perl into irssi itself.

I should have some time to work on this later today.

-David
Comment 2 Fernando Apesteguía freebsd_committer 2020-11-25 13:06:48 UTC
(In reply to David O'Rourke from comment #1)
Yes, at least when building with meson.
Comment 3 David O'Rourke 2020-11-25 23:03:15 UTC
Created attachment 219981 [details]
irc/irssi: Port always uses perl5

This patch ensures that the port always sets USES=perl5, as it is required during build when building with Meson.
Comment 4 David O'Rourke 2020-11-25 23:04:07 UTC
This patch should fix the issue, the port now builds successfully in Poudriere both with and without the Perl option.

-David
Comment 5 commit-hook freebsd_committer 2020-11-26 08:02:52 UTC
A commit references this bug:

Author: fernape
Date: Thu Nov 26 08:02:38 UTC 2020
New revision: 556320
URL: https://svnweb.freebsd.org/changeset/ports/556320

Log:
  irc/irssi: Unbreak when PERL=OFF

  In r556069 the port changed to build with meson. This requires perl to build
  regardles of the option PERL that allows perl scripts to be run in irssi.

  While here clarify pkg-message (sent by daniel.engberg.lists@pyret.net)

  PR:	251371 251360
  Submitted by:	dor.bsd@xm0.uk (maintainer)
  Reported by:	m.bueker@berlin.de

Changes:
  head/irc/irssi/Makefile
  head/irc/irssi/pkg-message
Comment 6 Fernando Apesteguía freebsd_committer 2020-11-26 08:07:54 UTC
Committed,

Thanks!
Comment 7 daniel.engberg.lists 2020-11-26 08:46:29 UTC
Isn't this slightly incorrect, it's only a build repo if perl is turned off?

ie:

USES= perl5

....

.include <bsd.port.options.mk>

.if ! ${PORT_OPTIONS:MPERL}
USE_PERL5=	build
.endif

....
Comment 8 daniel.engberg.lists 2020-11-26 08:47:31 UTC
Of course it should say build dep instead of build repo, sorry