Bug 251385 - devel/binutils: update to 2.35.1
Summary: devel/binutils: update to 2.35.1
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-11-25 17:04 UTC by Jose Fernando Lopez Fernandez
Modified: 2020-11-28 16:54 UTC (History)
1 user (show)

See Also:


Attachments
Patch to update devel/binutils to upstream version 2.35.1 (22.39 KB, patch)
2020-11-25 17:04 UTC, Jose Fernando Lopez Fernandez
jflopezfernandez: maintainer-approval+
Details | Diff
Revised patch updating devel/binutils port to 2.35.1 (18.97 KB, patch)
2020-11-26 07:25 UTC, Jose Fernando Lopez Fernandez
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Fernando Lopez Fernandez 2020-11-25 17:04:24 UTC
Created attachment 219971 [details]
Patch to update devel/binutils to upstream version 2.35.1

Good morning,

This is my first submission as the official maintainer of this port; any and all feedback is both welcome and appreciated.

Changes:

 * The 0b398d6, gas-configure, and libctf_swap patches were no longer required, as their changes have already been incorporated into the upstream branch.

Notes:

The patches for the s390* and aarch64 platforms required manual edits, but I made sure to copy over the changes exactly as they were in the previous version. However, I am not familiar with those platforms, nor do I have access to them to be able to test the changes, so please reach out to me with any problems.

You can email me at jflopezfernandez@gmail.com.
Comment 1 Fernando Apesteguía freebsd_committer 2020-11-25 18:24:20 UTC
^Triage: [tags] in issue Titles are deprecated.

^Triage: Simplifying title

^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.

There are some warnings from linters. Some of the are false positives, others are not.

Q/A:  Makefile: [141]: possible direct use of command "rm" found. use ${RM} instead.
 Makefile: new ports should not set PORTREVISION.
 Makefile: new ports should not set PORTEPOCH.
 Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
 Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
 Makefile: "PKGNAMEPREFIX" has to appear earlier.
 Makefile: "BROKEN_mips" has to appear earlier.
 Makefile: "BUILD_DEPENDS" has to appear earlier.
 Makefile: "USES" has to appear earlier.

^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html

Q/A: PORTREVISION should be removed


Thanks!
Comment 2 Jose Fernando Lopez Fernandez 2020-11-25 20:49:57 UTC
(In reply to Fernando Apesteguía from comment #1)

Good afternoon, thank you so much for your reply. I apologize for the errors; I will submit a corrected patch once the necessary modifications have been made.

Thank you again for your help,
Jose
Comment 3 Fernando Apesteguía freebsd_committer 2020-11-25 21:37:51 UTC
(In reply to Jose Fernando Lopez Fernandez from comment #2)

No need to apologise :-)

Just FYI, 

portlint, portclippy and portfmt are tools in ports that can help you with maintaining ports.
Comment 4 Jose Fernando Lopez Fernandez 2020-11-26 07:25:07 UTC
Created attachment 219991 [details]
Revised patch updating devel/binutils port to 2.35.1

(In reply to Fernando Apesteguía from comment #3)

This revised patch contains nearly all of the requested modifications, with the sole exception being the portlint changes. I was able to fix all but three of the warnings ("BROKEN", "BUILD_DEPENDS", and "USES"), as they rely on the particular flavor of the package the user is building. I believe page 209 of the Porter's Handbook makes a specific allowance for this case, but please do let me know if this is not correct.

All other portlint warnings have been fixed, and the package passes all QA tests and builds successfully with poudriere.

Thank you again for all of your help, and please do let me know if I have missed anything.

Jose

Change log for GNU binutils version 2.35.1:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob_plain;f=binutils/NEWS;hb=refs/tags/binutils-2_35_1
Comment 5 Fernando Apesteguía freebsd_committer 2020-11-26 11:48:48 UTC
(In reply to Jose Fernando Lopez Fernandez from comment #4)

Hi Jose,

Unfortunately, the port does not build. It fails at the patch phase:

===>  Applying FreeBSD patches for binutils-2.35.1,1 from /usr/ports/devel/binutils/files
Ignoring previously applied (or reversed) patch.
1 out of 1 hunks ignored--saving rejects to binutils/coffdump.c.rej
Ignoring previously applied (or reversed) patch.
1 out of 1 hunks ignored--saving rejects to binutils/srconv.c.rej
Ignoring previously applied (or reversed) patch.
1 out of 1 hunks ignored--saving rejects to binutils/sysdump.c.rej
===>  FAILED Applying FreeBSD patch-0b398d6.diff
===> FAILED to apply cleanly FreeBSD patch(es)  patch-0b398d6.diff
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/binutils

Would you have a look at it?
Comment 6 Jose Fernando Lopez Fernandez 2020-11-28 07:02:25 UTC
Hi, Fernando,

I will figure out what I did wrong first thing tomorrow morning. I promise future updates will not be this tedious; I am determined to get this right, but I am very embarrassed to have wasted so much of your time.

Thank you again, and I look forward to having an answer for you tomorrow morning.
Jose
Comment 7 Fernando Apesteguía freebsd_committer 2020-11-28 16:54:17 UTC
(In reply to Jose Fernando Lopez Fernandez from comment #6)

There is no rush :-)

Maintaining ports can be challenging, specially the complex ones.