Created attachment 220000 [details]
Patch for irssi
Instead of having Perl as a runtime dependency just set it as a build dependency when Perl support disabled. When Perl support is disabled there's also no need to install Perl scripts as they wont work.
Use INSTALL_DATA for installing sample config
Compile and run-time tested on FreeBSD 13.0-CURRENT #0 r367711 (make, make check-plist) with and without Perl support
Poudriere testport OK 12.2-RELEASE (amd64) (with and without Perl support)
Thanks again for another patch.
I'm currently poking about at this, I've also realised we'll need to be increasing PORTREVISION for each of these changes before they're committed.
It's only needed when the resulting binary and/or package changes.
Created attachment 220016 [details]
irc/irssi: Use Perl only for build when option disabled
This patch adds a few more fixes to the patch from Daniel Engberg:
- Bumping the PORTREVISION
- Removing the @dir entry for lib/irssi/modules
- This caused plist issues when no modules were built, as the irssi install no longer creates an empty directory in this case
Comment on attachment 220000 [details]
Patch for irssi
A patch with further fixes has been submitted.
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/221954941
A commit references this bug:
Date: Sun Nov 29 18:10:07 UTC 2020
New revision: 556594
irc/irssi: Fix Perl support option
Make Perl a run time option only when Perl option is selected. Perl is needed to
Submitted by: firstname.lastname@example.org (maintainer)
Reported by: email@example.com