Bug 251406 - irc/irssi: Fix Perl support option and minor Makefile fix
Summary: irc/irssi: Fix Perl support option and minor Makefile fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-11-26 14:15 UTC by daniel.engberg.lists
Modified: 2020-11-29 18:11 UTC (History)
3 users (show)

See Also:
dor.bsd: maintainer-feedback+


Attachments
Patch for irssi (1.68 KB, patch)
2020-11-26 14:15 UTC, daniel.engberg.lists
no flags Details | Diff
irc/irssi: Use Perl only for build when option disabled (1.81 KB, patch)
2020-11-26 22:56 UTC, David O'Rourke
dor.bsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description daniel.engberg.lists 2020-11-26 14:15:05 UTC
Created attachment 220000 [details]
Patch for irssi

Instead of having Perl as a runtime dependency just set it as a build dependency when Perl support disabled. When Perl support is disabled there's also no need to install Perl scripts as they wont work.

Use INSTALL_DATA for installing sample config

Compile and run-time tested on FreeBSD 13.0-CURRENT #0 r367711 (make, make check-plist) with and without Perl support
Poudriere testport OK 12.2-RELEASE (amd64) (with and without Perl support)
Comment 1 David O'Rourke 2020-11-26 20:44:39 UTC
Thanks again for another patch.

I'm currently poking about at this, I've also realised we'll need to be increasing PORTREVISION for each of these changes before they're committed.
Comment 2 daniel.engberg.lists 2020-11-26 21:46:36 UTC
It's only needed when the resulting binary and/or package changes.
Comment 3 David O'Rourke 2020-11-26 22:56:28 UTC
Created attachment 220016 [details]
irc/irssi: Use Perl only for build when option disabled

This patch adds a few more fixes to the patch from Daniel Engberg:

  - Bumping the PORTREVISION
  - Removing the @dir entry for lib/irssi/modules
    - This caused plist issues when no modules were built, as the irssi install no longer creates an empty directory in this case

-David
Comment 4 David O'Rourke 2020-11-26 22:57:07 UTC
Comment on attachment 220000 [details]
Patch for irssi

A patch with further fixes has been submitted.

-David
Comment 5 Automation User 2020-11-26 23:09:29 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/221954941
Comment 6 commit-hook freebsd_committer 2020-11-29 18:10:49 UTC
A commit references this bug:

Author: fernape
Date: Sun Nov 29 18:10:07 UTC 2020
New revision: 556594
URL: https://svnweb.freebsd.org/changeset/ports/556594

Log:
  irc/irssi: Fix Perl support option

  Make Perl a run time option only when Perl option is selected. Perl is needed to
  build always.

  PR:	251406
  Submitted by:	dor.bsd@xm0.uk (maintainer)
  Reported by:	daniel.engberg.lists@pyret.net

Changes:
  head/irc/irssi/Makefile
  head/irc/irssi/pkg-plist
Comment 7 Fernando Apesteguía freebsd_committer 2020-11-29 18:11:04 UTC
Committed,

Thanks!