Bug 251431 - ports-mgmt/portlint: [PATCH] quell warning about USE_LDCONFIG32
Summary: ports-mgmt/portlint: [PATCH] quell warning about USE_LDCONFIG32
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-28 00:27 UTC by Gerald Pfeifer
Modified: 2020-11-29 17:26 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
Proposed patch for portlint (367 bytes, patch)
2020-11-28 00:27 UTC, Gerald Pfeifer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer 2020-11-28 00:27:23 UTC
Created attachment 220036 [details]
Proposed patch for portlint

portlint -C currently issues the following warning in emulators/wine:

WARN: Makefile: [48]: is USE_LDCONFIG32 a user-settable option? Consider using WITH_LDCONFIG32 instead.

USE_LDCONFIG32 is not a user-settable option and should be excluded like
USE_GCC already is.

The proposed patch attached does this for me and I hope it appears useful.
(I'm not a Perl hacker, so feel free to discard in favor of a better one;
no hurt feelings.)
Comment 1 commit-hook freebsd_committer 2020-11-29 17:25:44 UTC
A commit references this bug:

Author: marcus
Date: Sun Nov 29 17:24:44 UTC 2020
New revision: 556590
URL: https://svnweb.freebsd.org/changeset/ports/556590

Log:
  Update to 2.19.3.

  * Do not complain about USE_LDCONFIG32 [1]
  * Allow a master port to have its last line be ".endif" [2]
  * Attempt to find OPTIONS use in a smarter way [3]

  PR:		251431 [1]
  		251430 [2]
  		249970 [3]
  Submitted by:	gerald [1]

Changes:
  head/ports-mgmt/portlint/Makefile
  head/ports-mgmt/portlint/src/portlint.pl
Comment 2 Joe Marcus Clarke freebsd_committer 2020-11-29 17:26:17 UTC
Committed to 2.19.3.  Thanks!