Bug 251438 - devel/golangci-lint: Update to 1.33.0
Summary: devel/golangci-lint: Update to 1.33.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL: https://github.com/golangci/golangci-...
Depends on:
Reported: 2020-11-28 14:33 UTC by Lewis Cook
Modified: 2020-12-01 07:18 UTC (History)
2 users (show)

See Also:

golangci-lint-1.33.0.diff (11.95 KB, patch)
2020-11-28 14:33 UTC, Lewis Cook
lcook: maintainer-approval+
Details | Diff
golangci-lint-1.33.0.diff (7.90 KB, patch)
2020-12-01 00:36 UTC, Lewis Cook
lcook: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Cook freebsd_committer freebsd_triage 2020-11-28 14:33:18 UTC
Created attachment 220043 [details]


 * https://github.com/golangci/golangci-lint/releases/v1.33.0


 * portlint: OK (looks fine).
 * testport: OK (poudriere: 12.2-RELEASE, amd64).

MFH: No (Dependency update).
Comment 1 Fernando Apesteguía freebsd_committer 2020-11-28 18:30:33 UTC
Q/A: patch did not apply cleanly. Would you mind checking it?

The patch is against 1.32.0 but in ports there is 1.32.2.

Comment 2 Rainer Hurling freebsd_committer 2020-11-28 21:01:22 UTC
Hi Lewis,

Your patch is against v1.32.0, while the port is 1.32.2. Could you please renew it?

Thanks in advance,
Comment 3 Rainer Hurling freebsd_committer 2020-11-28 21:02:25 UTC
(In reply to Rainer Hurling from comment #2)

Sorry, I missed, that Fernando already said the same ;)
Comment 4 Lewis Cook freebsd_committer freebsd_triage 2020-12-01 00:36:34 UTC
Created attachment 220123 [details]

Good catch, thank you both. :)
Comment 5 commit-hook freebsd_committer 2020-12-01 07:17:17 UTC
A commit references this bug:

Author: rhurlin
Date: Tue Dec  1 07:16:40 UTC 2020
New revision: 556721
URL: https://svnweb.freebsd.org/changeset/ports/556721

  devel/golangci-lint: Update to 1.33.0

  Minor release with a new paralleltest linter and some bug fixes.

  Changelog: https://github.com/golangci/golangci-lint/releases/v1.33.0

  PR:		251438
  Submitted by:	Lewis Cook <vulcan@wired.sh> (maintainer)
  Approved by:	arrowd (mentor)
  Differential Revision:	https://reviews.freebsd.org/D27432

Comment 6 Rainer Hurling freebsd_committer 2020-12-01 07:18:32 UTC
Committed, thanks :)