Bug 251447 - sysutils/iocage: RUN_DEPENDS on devel/py-pytest-runner and devel/rcs57
Summary: sysutils/iocage: RUN_DEPENDS on devel/py-pytest-runner and devel/rcs57
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-29 11:13 UTC by Mina Galić
Modified: 2020-11-29 12:45 UTC (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mina Galić 2020-11-29 11:13:27 UTC 
sysutils/iocage has a RUN_DEPENDS on devel/py-pytest-runner and devel/rcs57, which seems… wrong.

I'm not seeing those in https://github.com/iocage/iocage/blob/master/requirements.txt or here https://github.com/iocage/iocage/blob/master/setup.py

so where are those dependencies coming from?
Comment 1 Michael Gmelin freebsd_committer 2020-11-29 12:45:20 UTC 
The dependency on rcs57 is required to have the "merge" command in place (otherwise upgrading <12 jails on a 12-RELEASE jailhost breaks, which is a common upgrade path when upgrading a jailhost from 11 to 12). See bug #240177 and https://svnweb.freebsd.org/ports?view=revision&revision=512299

So this one will stay there for the foreseeable future.

The dependency on py-pytest-runner is less clear - it came in as part of the update to 0.9.8.1 (https://svnweb.freebsd.org/ports/head/sysutils/iocage/Makefile?r1=436928&r2=442376), which was before I maintained the port.

Removing it doesn't seem to have any immediate ill side-effects (build or runtime), but I don't have the time to test it thoroughly at the moment. Maybe Marcelo could shed some light on this. IMHO ideally we would keep it as a build time dependency and have a working test target, but remove the run-time dependency.