Bug 251448 - benchmarks/iperf: htonl argument issue on armv6
Summary: benchmarks/iperf: htonl argument issue on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-29 12:40 UTC by Martin Birgmeier
Modified: 2021-01-06 19:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch for fixing compilation of benchmarks/iperf on armv6 (2.39 KB, patch)
2020-11-29 12:40 UTC, Martin Birgmeier 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2020-11-29 12:40:13 UTC 
Created attachment 220059 [details]
patch for fixing compilation of benchmarks/iperf on armv6

Scenario:
- Raspberry Pi 1B+ or qemu-user-static (compiling natively or via qemu)
- FreeBSD 13.0-CURRENT #0 r367245M
- Trying to compile benchmarks/iperf

Result:
- The build fails with a type error in the arguments to htonl in src/Settings.cpp, regardless of compiling on the RPI-1B+ or via qemu

Note:
- On amd64 and i386 running release/12.2, the build succeeds

A (lightly tested) patch is attached, to be placed in benchmarks/iperf/files.

-- Martin
Comment 1 Martin Birgmeier 2020-12-17 17:51:45 UTC 
Comment on attachment 220059 [details]
patch for fixing compilation of benchmarks/iperf on armv6

It seems the patch does not work anymore, there are compile issues on both armv6 and i386 now.

-- Martin
Comment 2 Dimitry Andric freebsd_committer freebsd_triage 2020-12-31 12:29:53 UTC 
See also bug 252280 for the i386 fixes.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-01-03 20:45:39 UTC 
A commit references this bug:

Author: sunpoet
Date: Sun Jan  3 20:44:50 UTC 2021
New revision: 560245
URL: https://svnweb.freebsd.org/changeset/ports/560245

Log:
  Fix build on armv6

  PR:		251448
  Submitted by:	Martin Birgmeier <d8zNeCFG@aon.at>

Changes:
  head/benchmarks/iperf/files/patch-src-Settings.cpp
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2021-01-03 20:45:45 UTC 
Committed. Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-01-06 19:06:48 UTC 
A commit references this bug:

Author: sunpoet
Date: Wed Jan  6 19:05:47 UTC 2021
New revision: 560558
URL: https://svnweb.freebsd.org/changeset/ports/560558

Log:
  MFH: r560244 r560245

  Fix build on i386

  PR:		252280
  Reported by:	Victor Sudakov <vas@sibptus.ru>
  Submitted by:	dim

  Fix build on armv6

  PR:		251448
  Submitted by:	Martin Birgmeier <d8zNeCFG@aon.at>

Changes:
_U  branches/2021Q1/
  branches/2021Q1/benchmarks/iperf/files/patch-src-Settings.cpp
  branches/2021Q1/benchmarks/iperf/files/patch-src-histogram.c