Bug 251476 - deskutils/fet: update to 5.48.0
Summary: deskutils/fet: update to 5.48.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mikael Urankar
URL: https://lalescu.ro/liviu/fet/news.html
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2020-11-30 05:01 UTC by Zsolt Udvari
Modified: 2020-12-01 17:00 UTC (History)
2 users (show)

See Also:


Attachments
patch (917 bytes, patch)
2020-11-30 05:01 UTC, Zsolt Udvari
no flags Details | Diff
updated patch (927 bytes, patch)
2020-12-01 08:13 UTC, Zsolt Udvari
uzsolt: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari 2020-11-30 05:01:38 UTC
Created attachment 220095 [details]
patch

Simple update to 5.48.0.

Changelog:
Updated the code to be compliant with the future Qt 6.0.0.
Corrected a few warnings appearing with the new Qt 5.15.2 (about using deprecated Qt functions).
Corrected three minor warnings when compiling with clang.
heoretical improvement/logic bug fixed in the generation when using constraints of type students (set) early max beginnings at second hour without max gaps constraints or with more than zero max gaps allowed.
Added a warning if using constraints of type teacher(s)/students (set) max hours daily with weights less than 100%, because the algorithm is not perfectly implemented in this case.
Minor code improvements and cleanup.
Comment 1 Fernando Apesteguía freebsd_committer 2020-11-30 19:06:08 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.

Q/A: patch did not apply cleanly. Would you mind checking it?

Makefile in repo has two categories but your patch shows only one in the diff context and hence, it fails.


Thanks!
Comment 2 Zsolt Udvari 2020-12-01 08:13:25 UTC
Created attachment 220133 [details]
updated patch

Sorry, my ports tree was outdated.
Comment 3 commit-hook freebsd_committer 2020-12-01 16:59:38 UTC
A commit references this bug:

Author: mikael
Date: Tue Dec  1 16:59:31 UTC 2020
New revision: 556762
URL: https://svnweb.freebsd.org/changeset/ports/556762

Log:
  deskutils/fet: Update to 5.48.0

  Changelog:
    - Updated the code to be compliant with the future Qt 6.0.0.
    - Corrected a few warnings appearing with the new Qt 5.15.2
      (about using deprecated Qt functions).
    - Corrected three minor warnings when compiling with clang.
    - Theoretical improvement/logic bug fixed in the generation when using
      constraints of type students (set) early max beginnings at second hour
      without max gaps constraints or with more than zero max gaps allowed.
    - Added a warning if using constraints of type teacher(s)/students (set)
      max hours daily with weights less than 100%, because the algorithm is not
      perfectly implemented in this case.
    - Minor code improvements and cleanup.

  PR:		251476
  Submitted by:	Zsolt Udvari (maintainer)

Changes:
  head/deskutils/fet/Makefile
  head/deskutils/fet/distinfo
Comment 4 Mikael Urankar freebsd_committer 2020-12-01 17:00:14 UTC
Thanks!